Chore: isMobile refactor #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeremypress
commented
Mar 30, 2017
jeremypress
commented
- Moving isMobile to check the user agent
- Checking for mobile browser or ability to download when showing dl button
- making sure mobile browsers don't print due to text files not working
tonyjin
reviewed
Mar 30, 2017
| showDownloadButton(this.download); | ||
|
|
||
| if (checkFeature(this.viewer, 'print')) { | ||
| if (checkFeature(this.viewer, 'print') && !Browser.isMobile()) { |
There was a problem hiding this comment.
Do we need this mobile check? We're already in a (canDownload() || !Browser.isMobile()) if block right?
There was a problem hiding this comment.
yes because a browser like android chrome for example has the download attribute, but cannot print iFrames that we generate for text files.
tonyjin
approved these changes
Apr 3, 2017
pramodsum
added a commit
that referenced
this pull request
Nov 16, 2017
https://github.com/box/box-annotations/releases # 0.3.1 (2017-11-15) * Release: 0.3.1 ([6af2062](box/box-annotations@6af2062)) * Fix: Disable highlight creation when the mobile shared dialog is visible (#35) ([de7f392](box/box-annotations@de7f392)) * Fix: Ensure commentbox event listeners are bound properly (#37) ([fcce638](box/box-annotations@fcce638)) * Fix: Ensure newly created threads are set as inactive while saving (#38) ([8072fa8](box/box-annotations@8072fa8))
pramodsum
added a commit
to pramodsum/box-content-preview
that referenced
this pull request
Nov 21, 2017
https://github.com/box/box-annotations/releases # 0.4.0 (2017-11-21) * Chore: Cleanup annotations permissions (box#40) ([a52ed54](box/box-annotations@a52ed54)) * Fix: Activate annotation dialog on post (box#42) ([bc001be](box/box-annotations@bc001be)) * Fix: Disable highlight creation when the mobile shared dialog is visible (box#35) ([de7f392](box/box-annotations@de7f392)) * Fix: Don't clear reply textarea when annotation is added to dialog (box#36) ([1f88d55](box/box-annotations@1f88d55)) * Fix: Ensure commentbox event listeners are bound properly (box#37) ([fcce638](box/box-annotations@fcce638)) * Fix: Prevent creation of highlights when a point annotation is pending (box#41) ([42e29ce](box/box-annotations@42e29ce)) * Fix: Validate pendingThreadID when calling onSelectionChange() (box#39) ([10c1c98](box/box-annotations@10c1c98)) * Update: packages (box#43) ([97a91c3](box/box-annotations@97a91c3)) * Fix: Ensure newly created threads are set as inactive while saving (box#38) ([8072fa8](box/box-annotations@8072fa8))
pramodsum
added a commit
that referenced
this pull request
Nov 27, 2017
https://github.com/box/box-annotations/releases # 0.4.0 (2017-11-21) * Chore: Cleanup annotations permissions (#40) ([a52ed54](box/box-annotations@a52ed54)) * Fix: Activate annotation dialog on post (#42) ([bc001be](box/box-annotations@bc001be)) * Fix: Disable highlight creation when the mobile shared dialog is visible (#35) ([de7f392](box/box-annotations@de7f392)) * Fix: Don't clear reply textarea when annotation is added to dialog (#36) ([1f88d55](box/box-annotations@1f88d55)) * Fix: Ensure commentbox event listeners are bound properly (#37) ([fcce638](box/box-annotations@fcce638)) * Fix: Prevent creation of highlights when a point annotation is pending (#41) ([42e29ce](box/box-annotations@42e29ce)) * Fix: Validate pendingThreadID when calling onSelectionChange() (#39) ([10c1c98](box/box-annotations@10c1c98)) * Update: packages (#43) ([97a91c3](box/box-annotations@97a91c3)) * Fix: Ensure newly created threads are set as inactive while saving (#38) ([8072fa8](box/box-annotations@8072fa8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.