New: Separate create and view permissions for annotations #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables annotations to be shown in a view-only setting with the correct scopes Annotations permissions will be as follows: - can_annotate - whether a user can add any new annotations - can_view_annotations_all - whether a user can view all annotations - can_view_annotations_self - whether a user can view their own annotations (This is not yet supported as Preview is not aware of who the user previewing the file is in order to distinguish which annotations belong to the current user vs. other users)
pramodsum
commented
Sep 1, 2017
| @@ -162,7 +168,7 @@ class Annotator extends EventEmitter { | |||
| */ | |||
| showModeAnnotateButton(currentMode) { | |||
| const mode = this.modeButtons[currentMode]; | |||
| if (!mode || !this.isModeAnnotatable(currentMode)) { | |||
| if (!mode || !this.permissions.canAnnotate || !this.isModeAnnotatable(currentMode)) { | |||
There was a problem hiding this comment.
Ensures button to create point/draw annotations does not display
pramodsum
commented
Sep 1, 2017
| @@ -534,12 +540,20 @@ class Annotator extends EventEmitter { | |||
| fetchAnnotations() { | |||
| this.threads = {}; | |||
|
|
|||
| // Do not load any pre-existing annotations if the user does not have | |||
| // the correct permissions | |||
| if (!this.permissions.canViewAllAnnotations || !this.permissions.canViewOwnAnnotations) { | |||
There was a problem hiding this comment.
Does not fetch any annotations if the user cannot view any/their own annotations
pramodsum
commented
Sep 1, 2017
| // Hide delete button on plain highlights if user doesn't have | ||
| // permissions | ||
| if (annotations[0].permissions && !annotations[0].permissions.can_delete) { | ||
| if (!this.canAnnotate) { |
There was a problem hiding this comment.
Hides buttons in the plain highlight dialog if the user does not have can_annotate permissions
|
Tests coming soon! |
JustinHoldstock
approved these changes
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables annotations to be shown in a view-only setting with the correct scopes
Annotations permissions will be as follows: