Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove autobind for Office and Media files #505

Merged
merged 4 commits into from
Nov 22, 2017
Merged

Chore: Remove autobind for Office and Media files #505

merged 4 commits into from
Nov 22, 2017

Conversation

jeremypress
Copy link
Contributor

No description provided.

@boxcla
Copy link

boxcla commented Nov 21, 2017

Verified that @jeremypress has signed the CLA. Thanks for the pull request!

@jeremypress jeremypress changed the title Remove autobind for Office and Media files Chore: Remove autobind for Office and Media files Nov 21, 2017
const result = dash.onKeydown('blah');
expect(dash.toggleStats).to.not.be.called;
expect(result).to.not.be.true;
});
});

Copy link
Contributor

@pramodsum pramodsum Nov 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these. Seems like they were added on accident

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Contributor

@JustinHoldstock JustinHoldstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot! The 3D PR relies on this one, can't wait to get it in

@tonyjin tonyjin merged commit 0ecfd5e into box:master Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants