New: Enhanced pinch to zoom #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jeremypress has signed the CLA. Thanks for the pull request! |
src/lib/viewers/doc/DocBaseViewer.js
Outdated
| * @return {void} | ||
| */ | ||
| pinchToZoomEndHandler() { | ||
| if (this.zoomWrapper && this.isPinching) { |
There was a problem hiding this comment.
To remove a level of arrowness, you could do if(!this.zoomWrapper || !this.isPinching) return
JustinHoldstock
approved these changes
Jan 9, 2018
src/lib/util.js
Outdated
| } | ||
| } | ||
|
|
||
| return closestPage[0]; |
There was a problem hiding this comment.
Careful, this'll error out if closestPage is never set
src/lib/viewers/doc/DocBaseViewer.js
Outdated
| this.xOffset = xOrigin; | ||
| this.y = touchMidpoint[1]; | ||
| this.x = touchMidpoint[0]; | ||
| // |
src/lib/viewers/doc/DocBaseViewer.js
Outdated
| // PDF.js zoom | ||
| this.pdfViewer.currentScaleValue = this.pdfViewer.currentScale * this.pinchScale; | ||
|
|
||
| // // Scroll to correct position after zoom |
There was a problem hiding this comment.
extra // in comment (unless github is acting up)
as well as commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a WIP, but this PR adds a more fluid pinch-to-zoom by:
Open Issues: