Fix: Add blend mode fallbacks if not supported #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jeremypress has signed the CLA. Thanks for the pull request! |
JustinHoldstock
approved these changes
Apr 3, 2018
pramodsum
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows "legacy" highlight annotations to properly render in IE11, which by default does not support blend modes.
Current behavior:
with fix:
Is this reliable?
Normally, no. This workaround sets the opacity of the artifact in question to 0.5, whenever it encounters some kind of blending. If an opacity instruction for the given artifact appears after the blending instruction, the override will be replaced (this happens at an unknown frequency).
However, the code used to generate these annotations is written as follows:
This means we know that our blend instruction will come after the opacity instruction, so this override will work. This will also make some other blending issues more viewable on IE11, but not all, due to the reason described above.
Tests on the way, wanted to get this out ASAP to see how everyone feels.