Update: Wider thumbnails #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
jstoffan
previously approved these changes
Mar 25, 2019
jstoffan
previously approved these changes
Mar 26, 2019
| @@ -55,7 +55,6 @@ $thumbnail-sidebar-width: 201px; | |||
| flex: 1 0 auto; | |||
| overflow: hidden; | |||
| padding: 0; | |||
| width: 134px; | |||
There was a problem hiding this comment.
Yeah I don't think so because the flexbox width seems to take precedence
There was a problem hiding this comment.
I take it back, ie11 needs this, but I'll set it to the flex-basis instead
JustinHoldstock
previously approved these changes
Mar 26, 2019
added 2 commits
March 26, 2019 12:44
…-preview into wider-thumbnails
ConradJChan
dismissed stale reviews from JustinHoldstock and jstoffan
via
35bf279
JustinHoldstock
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the thumbnails sidebar width by 25px. Also decreases the selected state border to 3px
Before:
Now:
