Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update .podspec, remove -ObjC and -all_load flags #175

Closed
wants to merge 1 commit into from

Conversation

aletan
Copy link

@aletan aletan commented Feb 19, 2016

Fix conflict with other pods (example libjingle_peerconnection)

@boxcla
Copy link

boxcla commented Feb 19, 2016

Hi @aletan, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

@aletan
Copy link
Author

aletan commented Feb 19, 2016

CLA signed

@boxcla
Copy link

boxcla commented Feb 19, 2016

Verified that @aletan has just signed the CLA. Thanks, and we look forward to your contribution.

@RicoYao
Copy link

RicoYao commented Feb 24, 2016

@aletan Thanks for submitting this.

I believe the reason we added all_load was to have the categories compiled in. Without it, one might run into runtime errors (crashes). We should test that category methods still work with this, and also look into whether we need to use force_load instead of all_load.

@boxtcarpel
Copy link
Contributor

We have moved to using Carthage. Thank you for your pull request and for using the SDK.

@boxtcarpel boxtcarpel closed this Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants