Removing the set representation option method that used va_list param… #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jdizoglio has signed the CLA. Thanks for the pull request! |
Prithvijutur
approved these changes
Jun 13, 2018
scottliubox
reviewed
Jun 13, 2018
| @@ -86,6 +86,8 @@ typedef NS_OPTIONS(NSUInteger, BOXRepresentationRequestOptions) { | |||
|
|
|||
| - (void)setRepresentationRequestOptions:(BOXRepresentationRequestOptions)representationOptions args:(va_list)args; | |||
There was a problem hiding this comment.
Can we remove the header of the replaced method?
There was a problem hiding this comment.
yes, it was a miss. good catch
…eters to support the swift bridge, changing the method to an NSSet parameter. For consitentcy we should follow up migrating the objc set represetation option method as well.
scottliubox
approved these changes
Jun 13, 2018
jdizoglio
added a commit
that referenced
this pull request
Jun 13, 2018
…eters to support the swift bridge, changing the method to an NSSet parameter. For consitentcy we should follow up migrating the objc set represetation option method as well. (#541)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eters to support the swift bridge, changing the method to an NSSet parameter. For consitentcy we should follow up migrating the objc set represetation option method as well.