Download/Upload Progress#694
Merged
Merged
Conversation
|
Verified that @sujaygarlanka has signed the CLA. Thanks for the pull request! |
PJSimon
reviewed
Jan 6, 2020
PJSimon
left a comment
PJSimon
left a comment
Contributor
There was a problem hiding this comment.
Do you need to change the last lines of Gemfile.lock from:
BUNDLED WITH 2.0.1
to
BUNDLED WITH 2.1.0
This is a change you had made in the past.
Contributor
Author
|
That change was made when I recompiled the Gemfile in the previous PR. However, since nothing changed in the Gemfile when I compiled it last, I didn't compile it this time. However, one of the travis tests are not passing now, so I'll add in the change. |
PJSimon
approved these changes
Jan 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals ⚽
Implementation Details 🚧
Testing Details 🔍