Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download/Upload Progress #694

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Download/Upload Progress #694

merged 2 commits into from
Jan 6, 2020

Conversation

sujaygarlanka
Copy link
Contributor

@sujaygarlanka sujaygarlanka commented Jan 6, 2020

Goals ⚽

  • Add ability to view progress for uploads and downloads

Implementation Details 🚧

  • Add observer to progress object on a task

Testing Details πŸ”

  • Manual Testing

@boxcla
Copy link

boxcla commented Jan 6, 2020

Verified that @sujaygarlanka has signed the CLA. Thanks for the pull request!

Copy link
Member

@PJSimon PJSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to change the last lines of Gemfile.lock from:
BUNDLED WITH 2.0.1
to
BUNDLED WITH 2.1.0
This is a change you had made in the past.

@sujaygarlanka
Copy link
Contributor Author

That change was made when I recompiled the Gemfile in the previous PR. However, since nothing changed in the Gemfile when I compiled it last, I didn't compile it this time. However, one of the travis tests are not passing now, so I'll add in the change.

@sujaygarlanka sujaygarlanka merged commit 777a97d into master Jan 6, 2020
@sujaygarlanka sujaygarlanka deleted the dl/ul-progress branch January 6, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants