Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boxfolder): add method to get folder by path in BoxFolder class #655

Closed
wants to merge 2 commits into from
Closed

feat(boxfolder): add method to get folder by path in BoxFolder class #655

wants to merge 2 commits into from

Conversation

jgoldhammer
Copy link

Integrate possibility to get folder by path.
this behaviour is not documented in the official REST Api of Box, but the endpoint exists and is available in the box postman collection (https://developer.box.com/docs/box-postman-collection)

It would be nice when you can integrate this method.

@boxcla
Copy link

boxcla commented Nov 9, 2018

Hi @jgoldhammer, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

@jgoldhammer
Copy link
Author

CLA signed

@boxcla
Copy link

boxcla commented Nov 9, 2018

Verified that @jgoldhammer has just signed the CLA. Thanks, and we look forward to your contribution.

- integrate newer checkstyle version into gradle -> change checkstyle.xml due to new xml
- fix a few other warnings in other classes as well due to new checkstyle version
@coveralls
Copy link

coveralls commented Nov 9, 2018

Pull Request Test Coverage Report for Build 1761

  • 40 of 83 (48.19%) changed or added relevant lines in 18 files are covered.
  • 11 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.2%) to 58.644%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BackoffCounter.java 1 2 50.0%
src/main/java/com/box/sdk/BoxFile.java 0 1 0.0%
src/main/java/com/box/sdk/BoxTask.java 2 3 66.67%
src/main/java/com/box/sdk/BoxTaskAssignment.java 5 6 83.33%
src/main/java/com/box/sdk/LargeFileUpload.java 0 1 0.0%
src/main/java/com/box/sdk/ProgressInputStream.java 0 1 0.0%
src/main/java/com/box/sdk/ProgressOutputStream.java 0 1 0.0%
src/main/java/com/box/sdk/BoxCollaboration.java 1 4 25.0%
src/main/java/com/box/sdk/BoxUploadEmail.java 0 3 0.0%
src/main/java/com/box/sdk/BoxUser.java 7 11 63.64%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/BoxFolder.java 2 40.24%
src/main/java/com/box/sdk/BoxJSONResponse.java 2 93.33%
src/main/java/com/box/sdk/BoxAPIRequest.java 2 63.57%
src/main/java/com/box/sdk/BoxUser.java 2 57.32%
src/main/java/com/box/sdk/RealtimeServerConnection.java 3 80.0%
Totals Coverage Status
Change from base Build 1759: -0.2%
Covered Lines: 4603
Relevant Lines: 7849

💛 - Coveralls

@jgoldhammer
Copy link
Author

Hmm, the build fails in Java 7 due to Checkstyle- the new checkstyle does not work in Java 7 anymore. When I downgrade, the checkstyle task itself does not work anymore...

The coverage decreases additionally- but I hove no idea why?!

Can you help me here, @carycheng ?

@jgoldhammer
Copy link
Author

jgoldhammer commented Nov 9, 2018

@mattwiller
Copy link

@jgoldhammer Unfortunately, this API is not considered stable and is not ready for inclusion in the SDK. We'll add it to the SDK once the API is GA and publicly documented. In the meantime, if you want to call the API via the SDK, you can do so manually by constructing a BoxAPIRequest.

@jgoldhammer
Copy link
Author

Thanks for the info. I have done that- you can read it here...
https://medium.com/fme-developer-stories/box-rest-api-best-practices-a43c5a2a91bb

I will close the merge request.

@mattwiller mattwiller closed this Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants