Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File endpoints #359

Merged
merged 13 commits into from
Nov 1, 2018
Merged

File endpoints #359

merged 13 commits into from
Nov 1, 2018

Conversation

mattwiller
Copy link
Contributor

No description provided.

@boxcla
Copy link

boxcla commented Oct 29, 2018

Verified that @mattwiller has signed the CLA. Thanks for the pull request!

@coveralls
Copy link

coveralls commented Oct 29, 2018 •
edited

Pull Request Test Coverage Report for Build 1306

  • 92 of 95 (96.84%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 97.017%
Changes Missing Coverage Covered Lines Changed/Added Lines %
boxsdk/session/box_response.py 1 2 50.0%
boxsdk/object/file.py 71 73 97.26%
Totals Coverage Status
Change from base Build 1305: -0.01%
Covered Lines: 2537
Relevant Lines: 2615
💛 - Coveralls

jmoldow
jmoldow reviewed Oct 31, 2018
View reviewed changes
boxsdk/object/file.py Outdated Show resolved Hide resolved
boxsdk/object/file.py Outdated Show resolved Hide resolved
boxsdk/object/file.py Show resolved Hide resolved
boxsdk/pagination/marker_based_dict_collection.py Show resolved Hide resolved
@mattwiller mattwiller merged commit 1d73c6f into master Nov 1, 2018
@mattwiller mattwiller deleted the file_endpoints branch November 1, 2018 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmoldow jmoldow jmoldow left review comments

@Jeff-Meadows Jeff-Meadows Awaiting requested review from Jeff-Meadows

@carycheng carycheng Awaiting requested review from carycheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mattwiller @boxcla @coveralls @jmoldow