-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove obsoleteLoggingNetwork
docs from README
#783
Conversation
Allan Parsons seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
LoggingNetwork
docs from README
Pull Request Test Coverage Report for Build 3794932154
💛 - Coveralls |
Hi @allanparsons, |
@lukaszsocha2 this is blocked on an integration test. Since this is tagged with [docs] per the instruction(s), the merge shouldn't be blocked on tests. Can you force merge? |
@allanparsons it's blocked on licence. Integration tests check is optional. |
@lukaszsocha2 got it. license was signed prior to PR. I suspect we're waiting on someone on Box's legal side to click the button |
Ok let's wait a bit, maybe it will be resolved. If not, maybe a force push will be needed to retrigger the check. |
Can you force push this commit to retrigger check? |
'Allan Parsons seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.' |
c32b120
to
1b8449c
Compare
I guess it may be the case. Would you mind if I close this pr and open one by myself with exact same change? Or alternatively you could make your email public and check again. Tell me which one would you prefer |
Replaced by: PR #785 |
According to Change Log documentation, logging_network support was removed in version 2.0.0. README documentation was never updated to reflect this removal. This PR resolves that discrepancy between docs and changelog.