Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove obsoleteLoggingNetwork docs from README #783

Closed
wants to merge 2 commits into from

Conversation

allanparsons
Copy link
Contributor

According to Change Log documentation, logging_network support was removed in version 2.0.0. README documentation was never updated to reflect this removal. This PR resolves that discrepancy between docs and changelog.

@CLAassistant
Copy link

CLAassistant commented Dec 26, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ allanparsons
❌ Allan Parsons


Allan Parsons seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lukaszsocha2 lukaszsocha2 changed the title docs: removes obsolete logging_network docs from README docs: Remove obsoleteLoggingNetwork docs from README Dec 27, 2022
@coveralls
Copy link

coveralls commented Dec 27, 2022

Pull Request Test Coverage Report for Build 3794932154

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.516%

Totals Coverage Status
Change from base Build 3758880645: 0.0%
Covered Lines: 3404
Relevant Lines: 3640

💛 - Coveralls

@lukaszsocha2
Copy link
Contributor

Hi @allanparsons,
thanks for contributing. Can you sign our Contributor License Agreement so we can merge your pr?

@allanparsons
Copy link
Contributor Author

@lukaszsocha2 this is blocked on an integration test. Since this is tagged with [docs] per the instruction(s), the merge shouldn't be blocked on tests.

Can you force merge?

@lukaszsocha2
Copy link
Contributor

lukaszsocha2 commented Dec 27, 2022

@allanparsons it's blocked on licence. Integration tests check is optional.

image

@allanparsons
Copy link
Contributor Author

@lukaszsocha2 got it. license was signed prior to PR. I suspect we're waiting on someone on Box's legal side to click the button

@allanparsons
Copy link
Contributor Author

Screen Shot 2022-12-27 at 11 15 33 AM

@lukaszsocha2
Copy link
Contributor

Ok let's wait a bit, maybe it will be resolved. If not, maybe a force push will be needed to retrigger the check.

@lukaszsocha2
Copy link
Contributor

Can you force push this commit to retrigger check?

@lukaszsocha2
Copy link
Contributor

'Allan Parsons seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.'
Something is still missing

@allanparsons
Copy link
Contributor Author

There is an email bound to my account but it's private. See screenshot. Wonder if the license check is unable to view a private email address?
Screenshot 2022-12-28 at 10 10 56 AM

@lukaszsocha2
Copy link
Contributor

I guess it may be the case. Would you mind if I close this pr and open one by myself with exact same change? Or alternatively you could make your email public and check again. Tell me which one would you prefer

@allanparsons
Copy link
Contributor Author

Replaced by: PR #785

@allanparsons allanparsons deleted the fix-docs-logging_network branch December 30, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants