Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds get sign template and get sign templates methods on Client #835

Merged
merged 6 commits into from
Sep 6, 2023

Conversation

dtrodger
Copy link
Contributor

@dtrodger dtrodger commented Aug 1, 2023

Tell @PJSimon Dave Rodgers says hi :)

@coveralls
Copy link

coveralls commented Aug 11, 2023

Pull Request Test Coverage Report for Build 5831713999

  • 15 of 16 (93.75%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 93.526%

Changes Missing Coverage Covered Lines Changed/Added Lines %
boxsdk/client/client.py 9 10 90.0%
Files with Coverage Reduction New Missed Lines %
boxsdk/client/client.py 1 86.23%
Totals Coverage Status
Change from base Build 5725071206: 0.001%
Covered Lines: 3467
Relevant Lines: 3707

💛 - Coveralls

@congminh1254
Copy link
Member

Hi @dtrodger,
I have just added the tests for this sign templates, but it turned out that the response body from API is missing type field, it could make some issue while serialise the object.
So I'm contacting with the team who own this API to see if they can add that field to the request body, then we can merge this PR.
Thanks for your patience.
Regards,
Minh

@congminh1254 congminh1254 merged commit fbc783d into box:main Sep 6, 2023
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants