feat(sidebar): Toggle button #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
|
Will this preserve the behavior where clicking on a highlighted section (like the activity feed chat bubble), will also hide/show the sidebar? |
|
@booc0mtaco yep! |
jstoffan
reviewed
Jun 12, 2019
jstoffan
previously approved these changes
Jun 13, 2019
jstoffan
previously approved these changes
Jun 13, 2019
ConradJChan
commented
Jun 13, 2019
| <div className="bcs-SidebarNav-tabs"> | ||
| {hasActivity && ( | ||
| <SidebarNavButton | ||
| data-resin-target={SIDEBAR_NAV_TARGETS.ACTIVITY} |
There was a problem hiding this comment.
Decoupled the data-testid's from the constants used for the data-resin-target's
jstoffan
reviewed
Jun 13, 2019
| const SidebarNavButton = ({ children, interactionTarget, isOpen, onNavigate, sidebarView, tooltip }: Props) => { | ||
| const SidebarNavButton = ({ | ||
| children, | ||
| 'data-resin-target': dataResinTarget, |
There was a problem hiding this comment.
Can probably use ...rest, instead? Up to you.
jstoffan
approved these changes
Jun 13, 2019
j3tan
pushed a commit
to j3tan/box-ui-elements
that referenced
this pull request
Jul 9, 2019
* feat(sidebar): Toggle button * chore: PR comments and add unit tests * chore: fix classes * chore: add e2e tests * chore: update README.md * chore: decouple resin tags from data testids
alexkrolick
pushed a commit
to alexkrolick/box-ui-elements
that referenced
this pull request
Jul 10, 2019
* feat(sidebar): Toggle button * chore: PR comments and add unit tests * chore: fix classes * chore: add e2e tests * chore: update README.md * chore: decouple resin tags from data testids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: