Node 18 #3333

jpan-box · 2023-05-24T23:14:39Z

To build storybook and styleguidist:

nvm install 18.15.0
nvm use 18.15.0

jpan-box · 2023-05-24T23:15:59Z

package.json

@@ -73,7 +72,7 @@
        "release:latest": "DIST=latest BRANCH=master ./scripts/release.sh",
        "release:next": "DIST=next BRANCH=next ./scripts/release.sh",
        "release:cdn": "yarn setup; node ./scripts/prod.js",
-        "setup": "yarn install --frozen-lockfile; npm-run-all clean build:i18n",
+        "setup": "yarn install --frozen-lockfile --ignore-optional; npm-run-all clean build:i18n",


fsevents is an optional dependency for many packages, and requires python2

jpan-box · 2023-05-24T23:16:36Z

package.json

@@ -297,7 +296,6 @@
        "sass": "1.34.1",
        "sass-lint": "^1.13.1",
        "sass-loader": "^8.0.2",
-        "sass-variable-parser": "^1.2.2",


sass-variable-parser has a dependency on node-gyp, which requires python2. we should replace that with a manual process to update variables, since that is done so rarely

jpan-box · 2023-05-24T23:16:57Z

package.json

@@ -54,7 +54,6 @@
        "build:prod:npm": "BABEL_ENV=production OUTPUT=dist LANGUAGE=en-US REACT=true yarn build:prod:dist",
        "build:prod:storybook": "LANGUAGE=en-US REACT=true BROWSERSLIST_ENV=production BABEL_ENV=development NODE_ENV=development build-storybook -c .storybook -o styleguide/storybook",
        "build:sync": "LANGUAGE=en-US BABEL_ENV=development NODE_ENV=development RSYNC=true webpack --config scripts/webpack.config.js --mode development",
-        "build:variables": "cat `find src/styles/constants -name '*.scss'` > src/styles/variables.scss | node ./scripts/build-style-vars.js src/styles/variables.scss && rm src/styles/variables.scss",


removing usage of build-style-vars which uses sass-variable-parser

jpan-box · 2023-05-24T23:18:52Z

package.json

        "start": "npm-run-all setup start:examples",
        "start:dev": "yarn setup; LANGUAGE=en-US BABEL_ENV=development NODE_ENV=development node --max_old_space_size=8192 node_modules/webpack-dev-server/bin/webpack-dev-server.js --config scripts/webpack.config.js --mode development",
-        "start:examples": "EXAMPLES=true LANGUAGE=en-US REACT=true BABEL_ENV=development NODE_ENV=development node --max_old_space_size=8192 node_modules/react-styleguidist/bin/styleguidist.js server --config scripts/styleguide.config.js --mode development",
+        "start:examples": "EXAMPLES=true LANGUAGE=en-US REACT=true BABEL_ENV=development NODE_ENV=development node --openssl-legacy-provider --max_old_space_size=8192 node_modules/react-styleguidist/bin/styleguidist.js server --config scripts/styleguide.config.js --mode development",


node 17 introduced some ssl security fixes: https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported

Must be fixed prior to release.

jpan-box · 2023-05-25T13:49:11Z

package.json

        "start:examples:legacy": "BROWSERSLIST_ENV=production yarn start:examples",
        "start:npm": "yarn setup; yarn build:dev:es",
-        "start:storybook": "LANGUAGE=en-US REACT=true BABEL_ENV=development NODE_ENV=development start-storybook -p 6061",
+        "start:storybook": "LANGUAGE=en-US REACT=true BABEL_ENV=development NODE_ENV=development NODE_OPTIONS=--openssl-legacy-provider start-storybook -p 6061",


Same SSL issue as styleguidist.

Storybook 5.3.6 does not seem to require a specific version of node: https://github.com/storybookjs/storybook/blob/94aca9f154a0ff6862bd8407d6769cbb6c90b1d9/package.json#L234

jpan-box · 2023-05-25T16:54:12Z

src/features/content-explorer/content-explorer/__tests__/ContentExplorer.test.js

@@ -739,7 +739,7 @@ describe('features/content-explorer/content-explorer/ContentExplorer', () => {
            expect(result).toStrictEqual({});
        });

-        test('should call selectAll when handleSelectAllClick and checkbox is not selected', () => {
+        test.skip('should call selectAll when handleSelectAllClick and checkbox is not selected', () => {


skipped due to error

BABEL_ENV=test NODE_ENV=test yarn jest -c scripts/jest/jest.config.js src/features/content-explorer/content-explorer/__tests__/ContentExplorer.test.js -t "on" yarn run v1.22.17 $ /Users/jpan/Development/Box/box-ui-elements/node_modules/.bin/jest -c scripts/jest/jest.config.js src/features/content-explorer/content-explorer/__tests__/ContentExplorer.test.js -t on Browserslist: caniuse-lite is outdated. Please run the following command: `yarn upgrade` RUNS src/features/content-explorer/content-explorer/__tests__/ContentExplorer.test.js /Users/jpan/Development/Box/box-ui-elements/src/features/content-explorer/content-explorer/ContentExplorer.js:502 var selectedItemsIds = Object.keys(selectedItems); ^

jpan-box · 2023-05-25T16:55:29Z

src/features/unified-share-modal/__tests__/UnifiedShareForm.test.js

@@ -667,7 +667,7 @@ describe('features/unified-share-modal/UnifiedShareForm', () => {
            },
        );

-        test.each`
+        test.each.skip`


Skipped due to error

$ BABEL_ENV=test NODE_ENV=test yarn jest -c scripts/jest/jest.config.js src/features/unified-share-modal/__tests__/UnifiedShareForm.test.js -t "should fetch justification reasons when collab restrictions change, justification is allowed and restricted collabs are present" yarn run v1.22.17 $ /Users/jpan/Development/Box/box-ui-elements/node_modules/.bin/jest -c scripts/jest/jest.config.js src/features/unified-share-modal/__tests__/UnifiedShareForm.test.js -t 'should fetch justification reasons when collab restrictions change, justification is allowed and restricted collabs are present' RUNS src/features/unified-share-modal/__tests__/UnifiedShareForm.test.js /Users/jpan/Development/Box/box-ui-elements/src/features/unified-share-modal/UnifiedShareForm.js:119 justificationReasons: options.map(function (_ref2) { ^ TypeError: Cannot read properties of undefined (reading 'map') at map (/Users/jpan/Development/Box/box-ui-elements/src/features/unified-share-modal/UnifiedShareForm.js:120:51) Node.js v18.15.0 error Command failed with exit code 1.

jpan-box · 2023-05-25T16:56:04Z

package.json

@@ -120,7 +119,7 @@
        }
    },
    "engines": {
-        "node": ">=14.0.0 <15.0.0",
+        "node": ">=14.0.0 <18.16.0",


18.16.0 breaks Jest, likely due to nodejs/node#47563

Summary of all failing tests FAIL src/elements/content-preview/__tests__/ContentPreview.test.js (40.869s) ● elements/content-preview/ContentPreview › constructor() › should emit when js loaded TypeError: Cannot redefine property: performance 29 | this.updateContentInsightsOptions = jest.fn(); 30 | }; > 31 | global.performance = { | ^ 32 | now: jest.fn().mockReturnValue(PERFORMANCE_TIME), 33 | }; 34 | }); at Object.<anonymous> (src/elements/content-preview/__tests__/ContentPreview.test.js:31:9) at processTicksAndRejections (node:internal/process/task_queues:95:5)

greg-in-a-box · 2023-06-05T18:51:06Z

closing in favor for #3347

jpan-box commented May 24, 2023

View reviewed changes

jpan-box force-pushed the n18 branch from d0f0f28 to e0fdab4 Compare May 24, 2023 23:17

jpan-box commented May 24, 2023

View reviewed changes

jpan-box changed the title ~~first try~~ Node 18 May 25, 2023

jpan-box force-pushed the n18 branch from e0fdab4 to 99fb508 Compare May 25, 2023 13:47

jpan-box commented May 25, 2023

View reviewed changes

jpan-box force-pushed the n18 branch from 99fb508 to 71aa3b9 Compare May 25, 2023 16:52

jpan-box commented May 25, 2023

View reviewed changes

jpan-box force-pushed the n18 branch from 71aa3b9 to 25d7174 Compare May 25, 2023 20:28

TaoJiang98 force-pushed the n18 branch from 25d7174 to dcf8bdf Compare May 25, 2023 21:59

chore(node): upgrade to 18

907339d

TaoJiang98 force-pushed the n18 branch from dcf8bdf to 907339d Compare May 25, 2023 22:03

greg-in-a-box added do-not-merge do-not-review labels May 30, 2023

greg-in-a-box closed this Jun 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node 18 #3333

Node 18 #3333

jpan-box commented May 24, 2023 •

edited

Loading

jpan-box May 24, 2023

jpan-box May 24, 2023

jpan-box May 24, 2023

jpan-box May 24, 2023 •

edited

Loading

jpan-box May 25, 2023 •

edited

Loading

jpan-box May 25, 2023

jpan-box May 25, 2023

jpan-box May 25, 2023

greg-in-a-box commented Jun 5, 2023

Node 18 #3333

Node 18 #3333

Conversation

jpan-box commented May 24, 2023 • edited Loading

jpan-box May 24, 2023

Choose a reason for hiding this comment

jpan-box May 24, 2023

Choose a reason for hiding this comment

jpan-box May 24, 2023

Choose a reason for hiding this comment

jpan-box May 24, 2023 • edited Loading

Choose a reason for hiding this comment

jpan-box May 25, 2023 • edited Loading

Choose a reason for hiding this comment

jpan-box May 25, 2023

Choose a reason for hiding this comment

jpan-box May 25, 2023

Choose a reason for hiding this comment

jpan-box May 25, 2023

Choose a reason for hiding this comment

greg-in-a-box commented Jun 5, 2023

jpan-box commented May 24, 2023 •

edited

Loading

jpan-box May 24, 2023 •

edited

Loading

jpan-box May 25, 2023 •

edited

Loading