fix(sidebar): Don't display @mentions without getMentionWithQuery prop #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @pramodsum has signed the CLA. Thanks for the pull request! |
ConradJChan
previously approved these changes
Jan 9, 2019
jstoffan
previously approved these changes
Jan 9, 2019
|
Would be great to see an accompanying test, either unit or integration. |
|
Matches this change in box annotations box/box-annotations#323 This prevents this dropdown from appearing whenever the ApprovalCommentForm doesn't have the getMentionQuery method prop passed down. The example below is in Annotations but the same applies for the sidebar
|
JustinHoldstock
previously approved these changes
Jan 16, 2019
pramodsum
force-pushed
the
master
branch
2 times, most recently
from
6864ab6
to
24de786
Compare
JustinHoldstock
approved these changes
Jan 18, 2019
|
🎉 This PR is included in version 9.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.