fix: Creating BoxAuthenticationFailedException no longer throws an ex…

…ception (#790)
box · Jan 4, 2022 · 55a706e · 55a706e
1 parent 4f1f70a
commit 55a706e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/Box.V2/Exceptions/BoxAuthenticationFailedException.cs b/Box.V2/Exceptions/BoxAuthenticationFailedException.cs
@@ -24,9 +24,8 @@ protected internal BoxSessionInvalidatedException(string message, BoxError error
 
         protected internal static new BoxSessionInvalidatedException GetResponseException<T>(string message, IBoxResponse<T> response) where T : class
         {
-            var ex = BoxAPIException.GetResponseException(message, response);
-
-            return (BoxSessionInvalidatedException)ex;
+            var error = GetResponseError(response);
+            return new BoxSessionInvalidatedException(GetErrorMessage(message, response, error), response.Error, response.StatusCode, response.Headers);
         }
     }
 }
diff --git a/Box.V2/Exceptions/BoxException.cs b/Box.V2/Exceptions/BoxException.cs
@@ -61,6 +61,12 @@ protected internal BoxAPIException(string message, BoxError error, HttpStatusCod
         /// <param name="message">The message from the SDK about what happened</param>
         /// <param name="response">The HTTP response that generated the exception</param>
         protected internal static BoxAPIException GetResponseException<T>(string message, IBoxResponse<T> response) where T : class
+        {
+            var error = GetResponseError(response);
+            return new BoxAPIException(GetErrorMessage(message, response, error), response.Error, response.StatusCode, response.Headers);
+        }
+
+        protected internal static BoxError GetResponseError<T>(IBoxResponse<T> response) where T : class
         {
             BoxError error = null;
             if (!string.IsNullOrWhiteSpace(response.ContentString))
@@ -76,12 +82,11 @@ protected internal BoxAPIException(string message, BoxError error, HttpStatusCod
                     Debug.WriteLine(string.Format("Unable to parse error message: {0} ({1})", response.ContentString, e.Message));
                 }
             }
-            var ex = new BoxAPIException(GetErrorMessage(message, response, error), response.Error, response.StatusCode, response.Headers);
 
-            return ex;
+            return error;
         }
 
-        private static string GetErrorMessage<T>(string message, IBoxResponse<T> response, BoxError error = null) where T : class
+        protected internal static string GetErrorMessage<T>(string message, IBoxResponse<T> response, BoxError error = null) where T : class
         {
             var requestID = error?.RequestId;
             string traceID = null;