feat!: upgrade .net framework to 4.6.2, remove deprecated methods, remove use_index references, return proper object from GetFileVersionsUnderRetentionForAssignmentAsync
#881
Conversation
…rAssignmentAsync` method (#875)
…into version-5
| @@ -1,40 +1,29 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>netcoreapp2.0;netcoreapp2.2;netcoreapp3.1;net5.0;net6.0;net45</TargetFrameworks> | |||
| <TargetFrameworks>netcoreapp2.0;netcoreapp2.2;netcoreapp3.1;net5.0;net6.0;net462</TargetFrameworks> | |||
There was a problem hiding this comment.
is there a reason why you keep targeting core beyond EOL? Currently, only net6 and net7 are supported, see here. I'm ignoring the .net framework, haven't worked with it for a few years :)
There was a problem hiding this comment.
Our Box.V2.Core package still targets .NET 2.0 standard, which technically still supports old versions of .NET Core. To reflect that we target these versions in our test projects.
This is a relic from the past. We currently have two packages that we produce from the same code base. One that targets the good old .NET Framework and another that targets .NET Standard (the goal for it is to be used with .NET Core). This is not an ideal scenario, as we could simply have one package that targets .NET Standard because it supports both Core and Framework or target .NET Core explicitly in one of the packages, so we could officially drop support for those old versions and target the current one. This is something we might consider in the future, as it could break some of our clients. We don't use e.g. new language features from newer .NET so I don't think it's super important at the moment.
No description provided.