Fix auth retry for expired claim #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PJSimon
changed the title
sujaygarlanka
approved these changes
Sep 29, 2020
This was referenced Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug discovered in #645 and #693 where we were not properly reading the error code and description from the exception thrown for an expired claim ("clock skew").
This bug was preventing any requests to be retried and from returning the actual expired claim exception to the client.
Now that retries should occur properly when there is "clock skew" between the client and server, the JWT assertion should be created using the Box server time found in the response headers, which should result in a successful authentication on the first retry.