test: migrate old tests to the new test framework #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename new integration test project
increate timeout on disposition_at test
…-windows-sdk-v2 into sdk-1976-remove-appveyor
antusus
reviewed
Feb 18, 2022
|
|
||
| var result = await UserClient.FoldersManager.RemoveWatermarkAsync(folder.Id); | ||
|
|
||
| Assert.IsTrue(result); |
There was a problem hiding this comment.
Why not do this in a BDD way - which for me is way better in Integration Tests:
Add watermark to folder,
check information,
get watermark
then remove
I this test if the ApplyWatermarkAsync fails would the test still pass as remove would succeed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate all tests that were previously running on AppVeyor. Fixes #399.