Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing fields of EventSource #956

Merged
merged 5 commits into from
Jun 21, 2024
Merged

fix: Add missing fields of EventSource #956

merged 5 commits into from
Jun 21, 2024

Conversation

congminh1254
Copy link
Member

Closes: #955

@congminh1254 congminh1254 mentioned this pull request Jun 19, 2024
Closed
@congminh1254 congminh1254 changed the title fix: Add missing fields of EventSource fix: Add missing fields of EventSource Jun 19, 2024
mwwoda
mwwoda approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@mwwoda mwwoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@congminh1254 congminh1254 merged commit 138eda5 into main Jun 21, 2024
8 of 9 checks passed
@congminh1254 congminh1254 deleted the update-event-source branch June 21, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmagnuson wmagnuson wmagnuson left review comments

@mwwoda mwwoda mwwoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event Source Serialization Issues
3 participants
@congminh1254 @mwwoda @wmagnuson