Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support note to the mdfilter equality check in search #253

Merged
merged 6 commits into from Aug 6, 2021
Merged

Add support note to the mdfilter equality check in search #253

merged 6 commits into from Aug 6, 2021

Conversation

mhagmajer
Copy link
Contributor

@mhagmajer mhagmajer commented Jul 29, 2021 •
edited

Verified that:

[{
    scope: 'enterprise_27335',
    templateKey: 'VendorContract',
    filters: {
        value: {
            lt: 436442,
            gt: 436442,
        },
    },
}]|

is a valid argument for numeric equality search using mdfilter and the correct way for doing equality check https://developer.box.com/guides/search/metadata-filters/.

@mhagmajer mhagmajer requested review from PJSimon and mwwoda July 29, 2021 10:28
mwwoda
mwwoda reviewed Aug 5, 2021
View reviewed changes
Copy link
Contributor

@mwwoda mwwoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Changelog

@mhagmajer
Copy link
Contributor Author

@mwwoda thanks for pointing this out @mwwoda! I've updated the changelog

@mhagmajer mhagmajer requested a review from mwwoda August 5, 2021 09:58
@mhagmajer mhagmajer merged commit 142222a into main Aug 6, 2021
@mhagmajer mhagmajer deleted the mh/SDK-1707 branch August 6, 2021 10:15
mhagmajer added a commit that referenced this pull request Jan 27, 2022
@mhagmajer
Add support note to the mdfilter equality check in search (#253)
efb801b 
* Add support note to the mdfilter equality check in search

* throw if equality used with numeric data

* fix equality for numbers

* fix

* update changelog
mhagmajer added a commit that referenced this pull request Jan 27, 2022
@sujaygarlanka @swfree
@mhagmajer @dependabot @mwwoda @antusus
feat: Add OAuth2 support (#240)
d1a0227 
* wip

* oauth working

* clean up

* clean up

* add nicer logged in page and refactor some code

* Update default branch from master to main (#243)

* Insensitive language: replace whitelist with allowlist (#247)

* Insensitive language: replace whitelist with allowlist

* req changes

* add sensitive event types (#252)

* Bump lodash from 4.17.13 to 4.17.21 (#244)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.13 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.13...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump normalize-url from 4.5.0 to 4.5.1 (#248)

Bumps [normalize-url](https://github.com/sindresorhus/normalize-url) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/sindresorhus/normalize-url/releases)
- [Commits](https://github.com/sindresorhus/normalize-url/commits)

---
updated-dependencies:
- dependency-name: normalize-url
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump dot-prop from 4.2.0 to 4.2.1 (#216)

Bumps [dot-prop](https://github.com/sindresorhus/dot-prop) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/sindresorhus/dot-prop/releases)
- [Commits](sindresorhus/dot-prop@v4.2.0...v4.2.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marcin Hagmajer <mhagmajer@users.noreply.github.com>

* Bump bl from 1.2.2 to 1.2.3 (#215)

Bumps [bl](https://github.com/rvagg/bl) from 1.2.2 to 1.2.3.
- [Release notes](https://github.com/rvagg/bl/releases)
- [Commits](rvagg/bl@v1.2.2...v1.2.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marcin Hagmajer <mhagmajer@users.noreply.github.com>

* Bump ini from 1.3.5 to 1.3.8 (#225)

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marcin Hagmajer <mhagmajer@users.noreply.github.com>

* Add support note to the mdfilter equality check in search (#253)

* Add support note to the mdfilter equality check in search

* throw if equality used with numeric data

* fix equality for numbers

* fix

* update changelog

* Bump hosted-git-info from 2.6.0 to 2.8.9 (#245)

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.6.0 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.6.0...v2.8.9)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marcin Hagmajer <mhagmajer@users.noreply.github.com>

* Update README.md

* Add new API for files and file versions under retention (#250)

* Bump path-parse from 1.0.5 to 1.0.7 (#254)

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.5 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Adding support for sign request (#258)

* Support Metadata Query API (#259)

* fix: folder:collaborations:add make role a required flag (SDK-1070) (#261)

* fix: folder:collaborations:add make role a required flag (SDK-1070)

* changelog

* fix

* fix

* fix test

* lint

* Fixed shared-links example

* Fixed shared-links delete example. (#262)

* prettier

* provide instructions for login, code fixes

* chore: enforce conventional commits (#268)

* fixes

* fixes

* handle token failure

* package-lock

* package-lock for Node 10.10.0

* Drop support for Node 10

* Travis Node 12

* test

* test

* test more

* lower treshold

* build

* fix lint

Co-authored-by: Skye Free <skye.free@gmail.com>
Co-authored-by: Marcin Hagmajer <mhagmajer@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mateusz Woda <mwoda@box.com>
Co-authored-by: Kamil Berdychowski <kberdychowski@box.com>
Co-authored-by: Marcin Hagmajer <mhagmajer@box.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJSimon PJSimon PJSimon approved these changes

@mwwoda mwwoda mwwoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhagmajer @PJSimon @mwwoda