-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytest flaky interaction causing fixture exceptions to be ignored #120
Comments
tomasji
pushed a commit
to tomasji/flaky
that referenced
this issue
Feb 21, 2017
When a pytest test case fails during setup (either in a fixture or setup_method/setup_class), flaky should handle that kind of situation.
Hi guys!
Could you please let us know when it will be fixed? |
nmalaguti
added a commit
to nmalaguti/flaky
that referenced
this issue
May 24, 2017
nmalaguti
added a commit
to nmalaguti/flaky
that referenced
this issue
May 24, 2017
nmalaguti
added a commit
to nmalaguti/flaky
that referenced
this issue
Jun 12, 2017
If there is a failure on setup, fail the test case no matter what flaky settings are configured. We do not retry on setup failures because xdist has issues when attempting to retry setup failures. Fixes box#120
nmalaguti
added a commit
to nmalaguti/flaky
that referenced
this issue
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Somewhat related to this issue which was supposedly resolved in Flaky 3.1.1
In the example below, something in flaky is causing the exception that is thrown inside the fixture not to be reported anymore.
The test results show that 3 tests were gathered but none were executed (which is true) but leaves no trace to the exception in the fixture.
If we remove the flaky decorator from the test class, the error is reported normally.
The text was updated successfully, but these errors were encountered: