Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest 4.1 compatibility #140

Merged
merged 1 commit into from
Jan 7, 2019
Merged

pytest 4.1 compatibility #140

merged 1 commit into from
Jan 7, 2019

Conversation

gaborbernat
Copy link
Contributor

Resolves #139.

@boxcla
Copy link

boxcla commented Jan 7, 2019

Hi @gaborbernat, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

@gaborbernat
Copy link
Contributor Author

CLA signed

@boxcla
Copy link

boxcla commented Jan 7, 2019

Verified that @gaborbernat has just signed the CLA. Thanks, and we look forward to your contribution.

@gaborbernat
Copy link
Contributor Author

@Jeff-Meadows can we do a quick release with this?

@RonnyPfannschmidt
Copy link

please ensure correct version pins, else this breaks on older pytest versions

@gaborbernat
Copy link
Contributor Author

flaky does not have any references to pytest, just implicitly. I suppose we could have an if/else to keep the old for older versions. Can we use pytest.__version__ for that?

@RonnyPfannschmidt
Copy link

getattr(CallInfo, 'from_call', CallInfo)(...) should be a sufficient way to sort it out

@gaborbernat
Copy link
Contributor Author

@RonnyPfannschmidt changed.

@@ -269,7 +269,7 @@ def call_runtest_hook(self, item, when, **kwds):
"""
hookname = "pytest_runtest_" + when
ihook = getattr(item.ihook, hookname)
call_info = CallInfo(
call_info = getattr(CallInfo, "from_call", CallInfo)(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add a link to the pr changing the internal api for later comprehension here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants