Refactor pytest plugin to not monkey patch call_runtest_hook. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous refactor (#74) enabled this, but I didn't notice. Previously, flaky stored information about test reruns inside a CallInfo subclass. call_runtest_hook was monkey patched so that flaky could ensure that subclass was created. #74 moved that info into the plugin, so the monkey patch was no longer doing anything special. However, over time, flaky's implementation diverged from pytest's. This caused #139 and #156. This commit removes the monkey patch, and flaky now uses pytest's implementation, which fixes those issues and is more future proof.
|
Verified that @Jeff-Meadows has signed the CLA. Thanks for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous refactor (#74) enabled this, but I didn't notice.
Previously, flaky stored information about test reruns inside a
CallInfo subclass. call_runtest_hook was monkey patched so that
flaky could ensure that subclass was created. #74 moved that info
into the plugin, so the monkey patch was no longer doing anything
special.
However, over time, flaky's implementation diverged from pytest's.
This caused #139 and #156.
This commit removes the monkey patch, and flaky now uses pytest's
implementation, which fixes those issues and is more future proof.