Change getService() to throw error when service does not exist #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @j3tan has signed the CLA. Thanks for the pull request! |
| * @returns {boolean} True, if service exist. False, otherwise. | ||
| */ | ||
| hasService: function(serviceName) { | ||
| return serviceName in services; |
There was a problem hiding this comment.
I'd switch to hasOwnProperty() here. Right now, this will return true when serviceName is toString, hasOwnProperty, etc.
…ce. Add hasService() method. fixes #89
j3tan
force-pushed
the
throw_errors_for_non_existent_services
branch
from
56802c1
to
aac1ca8
Compare
|
+2 |
j3tan
added a commit
that referenced
this pull request
Sep 11, 2015
Change getService() to throw error when service does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #89