added error handling override function

[sinkingrowboats]

No description provided.

[boxcla]

Verified that @sinkingrowboats has signed the CLA. Thanks for the pull request!

[zephraph]

@j3tan I'm assuming that this is going to fail due to the eslint rule no-function-assign. Is this approach acceptable? Should we do something different?

[zephraph]

@j3tan Could you review? I suspect you'll want us to change this approach in favor of one that doesn't do function reassignment how it was approached here.

[j3tan]

Here's the approach I would take:

Create a variable at the top of this file, next to initialized = false;

var customErrorHandler;

then you could do:
customErrorHandler = exceptionHandler;

then do:

function error(exception) {
    if (customErrorHandler) {
         customErrorHandler(exception);
         return;
    }

    if (globalConfig.debug) ...
}

This will maintain the integrity of Box.Application while still giving you a handle/callback

[zephraph]

Failing due to test coverage, I'll add those sometime today.

[j3tan]

Code looks good. You can even be safer and do the following:

if (typeof customErrorHandler === 'function') {
   ...
}

[j3tan]

please include tests, then we can merge this in!

[zephraph]

Added a test. Didn't really stress test all of the use cases, though I can if you want. We should also probably add some extra documentation around this.

[j3tan]

Last request: please link to issue ticket # in commit description

[zephraph]

On every commit? Or do you want us to squash and have one commit with the ticket number in it?

[j3tan]

Squash is preferable, helps with commit history

[zephraph]

@j3tan I squashed everything. Could you give it one last look over?

Thanks!