Skip to content

Commit

Permalink
Add a comment about why we don't "make install" for every test.
Browse files Browse the repository at this point in the history
Change directory using absolute paths for safety and clarity.
  • Loading branch information
qris committed Aug 3, 2016
1 parent bc4b648 commit 5f8ba11
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions runtest.pl.in
Expand Up @@ -143,6 +143,9 @@ sub runtest
"cmake -E remove_directory $test_dst_dir",
"cmake -E copy_directory $test_src_dir $test_dst_dir",
"cmake -E copy $test_src_exe $test_dst_dir/$test_dst_exe",
# We could do a "make install" here, to ensure that everything
# is up to date, but it's really slow, verbose and wasteful:
# "cmake --build infrastructure/cmake/build --target install",
);

# Our CMake buildsystem doesn't do anything to support testextra files
Expand Down Expand Up @@ -213,7 +216,7 @@ sub runtest
{
# no tee.exe on Windows, so let's do it ourselves.
open LOG, ">$logfile" or die "$logfile: $!";
chdir("$test_mode/test/$t");
chdir(dirname($0)."/$test_mode/test/$t");

open TEE, "$test_dst_exe |"
or die "$test_dst_dir/$test_dst_exe: $!";
Expand All @@ -225,7 +228,7 @@ sub runtest
}
close LOG;
close TEE;
chdir("../../..");
chdir(dirname($0));
}
else
{
Expand Down

0 comments on commit 5f8ba11

Please sign in to comment.