Fix warning that overloaded method hides inherited ones

Make this warning an error to prevent it from happening again.
boxbackup · Dec 6, 2016 · ef80b5a · ef80b5a
1 parent 6115c93
commit ef80b5a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/infrastructure/m4/boxbackup_tests.m4 b/infrastructure/m4/boxbackup_tests.m4
@@ -19,6 +19,11 @@ AX_CHECK_COMPILE_FLAG(-Werror=non-virtual-dtor,
 	[cxxflags_strict="$cxxflags_strict -Werror=non-virtual-dtor"])
 AX_CHECK_COMPILE_FLAG(-Werror=delete-non-virtual-dtor,
 	[cxxflags_strict="$cxxflags_strict -Werror=delete-non-virtual-dtor"])
+# We should really enable -Werror=sometimes-uninitialized, but QDBM violates it:
+dnl AX_CHECK_COMPILE_FLAG(-Werror=sometimes-uninitialized,
+dnl 	[cxxflags_strict="$cxxflags_strict -Werror=sometimes-uninitialized"])
+AX_CHECK_COMPILE_FLAG(-Werror=overloaded-virtual,
+	[cxxflags_strict="$cxxflags_strict -Werror=overloaded-virtual"])
 AC_SUBST([CXXFLAGS_STRICT], [$cxxflags_strict])
 
 if test "x$GXX" = "xyes"; then

diff --git a/test/bbackupd/testbbackupd.cpp b/test/bbackupd/testbbackupd.cpp
@@ -1330,6 +1330,7 @@ class KeepAliveBackupProtocolLocal : public BackupProtocolLocal2
 		mNumKeepAlivesReceived++;
 		return response;
 	}
+	using BackupProtocolLocal2::Query;
 };
 
 bool test_ssl_keepalives()