Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the obsolete and non-functional file manager #932

Merged
merged 2 commits into from Aug 8, 2021
Merged

Remove the obsolete and non-functional file manager #932

merged 2 commits into from Aug 8, 2021

Conversation

BelleNottelling
Copy link
Collaborator

@BelleNottelling BelleNottelling commented Aug 8, 2021

This doesn't even work right in the current versions of PHP, is show to be the worst quality code by code analysis, and a file manager belongs in the server control panel anyways.
As a bonus, this is about the same size as the fonts we just merged in so we're to the same file size as before

@John-S4
Copy link
Contributor

John-S4 commented Aug 8, 2021

I agree with this. See #933

@BelleNottelling
Copy link
Collaborator Author

All checks have passed, we have 543 less code issues in our repository, and this module never made sense to me. Merging!

@BelleNottelling BelleNottelling merged commit b670599 into boxbilling:master Aug 8, 2021
@BelleNottelling BelleNottelling deleted the Remove-Filemanager branch August 8, 2021 01:57
@evrifaessa evrifaessa added deprecated For issues or pull requests involving fixes or replacements made to deprecated dependencies. enhancements Issues and Pull Requests involving possible enhancements to BoxBilling. cleanup Just some cleanup labels Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Just some cleanup deprecated For issues or pull requests involving fixes or replacements made to deprecated dependencies. enhancements Issues and Pull Requests involving possible enhancements to BoxBilling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants