Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent unnecessary requests to Secrets Managers #28

Closed
matthewdevenny opened this issue Oct 27, 2021 · 0 comments · Fixed by #25
Closed

Prevent unnecessary requests to Secrets Managers #28

matthewdevenny opened this issue Oct 27, 2021 · 0 comments · Fixed by #25
Assignees
@matthewdevenny

Comments

@matthewdevenny
Copy link
Member

dockhand-secrets-operator uses rancher/wrangler to write the Dockhand Secret controller. The on change controller is periodically executed and currently the controller.onDockhandSecretChange method will query the secrets manager backends each time. The controller should store an observedGeneration field in the State and only query the Secrets Manager if the metadata.generation does not match the observedGeneration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewdevenny matthewdevenny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CRDs boxboat/dockhand-secrets-operator
1 participant
@matthewdevenny