Fix ssh references in WinRM and templates #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in these 2 places: - output filename in the vagrant postprocessor (i.e. after ~45 minutes of building the machine: "why the hell is my WinRM machine named something-ssh-something? did I choose the wrong template?" :-) - template used in the vagrant postprocessor However in win2012r2-standardcore, `ssh` was also in the path to `Autounattend.xml` that is used for the floppy. What is more, the ssh path reference there however does not exist.
- some templates had box names and defines inconsistent with template file name (`ssh-ssh` instead of `ssh`, or `standard-sshcore` instead of `standardcore-ssh`) - some templates had improperly commented ssh port forwarding - one template (`*ssh-ssh`) is not referenced anywhere
Closed
rasa
added a commit
that referenced
this pull request
Nov 28, 2015
Fix ssh references in WinRM and templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove references to "ssh" in winrm builds. This is in these 2 places:
vagrantpostprocessor (i.e. after ~45 minutesof building the machine: "why the hell is my WinRM box named
"something-ssh-something"? did I choose the wrong template?" :-)
However in win2012r2-standardcore,
sshwas also in the path toAutounattend.xmlthat is used for the floppy. What is more, the ssh pathreference there however does not exist.
Also make order in
tplw.r.t. ssh (second commit):file name (
ssh-sshinstead ofssh, orstandard-sshcoreinsteadof
standardcore-ssh)*ssh-ssh) is not referenced anywhereI do not have intimate knowledge of this project and of course did not
test with all templates, so please review the changes I did. I simply
used common sense to remove apparent inconsistencies, with the hope the
inconsistencies are not intentional but caused by a mistake.