Handle annotated assignment in 3.6 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 3.6, annotated assignment was added, which takes the form of `a: int = 0`. This would cause errors, since `:` is an operator, and its child would contain nodes of type `annassign`. We handle these the same way that we handle normal assignments, but by dropping into the assignment logic at an offset in the expression we're handling.
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 87.23% 87.35% +0.12%
==========================================
Files 3 3
Lines 525 530 +5
==========================================
+ Hits 458 463 +5
Misses 67 67
Continue to review full report at Codecov.
|
|
Great! Thanks for this. Do you need a release with this right now? |
|
Nah, this can wait for your normal release cadence. Thanks for the offer though!! And thanks for the merge!
El 4 de octubre de 2018 11:45:23 p. m. PDT, "Anders Hovmöller" <notifications@github.com> escribió:
…Great! Thanks for this. Do you need a release with this right now?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#23 (comment)
--
Enviado desde mi dispositivo Android con K-9 Mail. Por favor, disculpa mi brevedad.
|
|
I've made a release now. I must admit that I don't really have a release cadence! The project is mostly done excepting some fairly major ideas I have that might or might not be a good idea :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3.6, annotated assignment was added, which takes the form of
a: int = 0.This would cause errors, since
:is an operator, and its child would containnodes of type
annassign.We handle these the same way that we handle normal assignments, but by dropping
into the assignment logic at an offset in the expression we're handling.