-
Notifications
You must be signed in to change notification settings - Fork 883
Conversation
This fixes boxen#235 in a more permanent way
it looks fine to me @fromonesrc or @skottler second thumbs up? |
Messages like |
Ok, will change! 👍 |
Also changed to boxen standard of "No message if nothing changes"
@skottler I've made the changes you asked for, look good? 👍 |
@fromonesrc @skottler any thoughts? 👍 |
Hey, |
GID=`id -g` | ||
USERNAME=`id -u -nr` | ||
|
||
if grep $GID /etc/group >/dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just negate the condition, since you've got an empty then
clause
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 👍
@dgoodlad made the changes, it's no longer automatic. Can you merge? 👍 |
@dgoodlad poke |
Conflicts: script/bootstrap
@dgoodlad ping! 😄 |
Add a script to create a fake group
Pong! 😁 |
Ty! 💃 |
This fixes #235 in a more permanent way 👍