Skip to content
This repository has been archived by the owner on May 22, 2018. It is now read-only.

Add a script to create a fake group #581

Merged
merged 5 commits into from
Dec 21, 2014
Merged

Conversation

petems
Copy link
Member

@petems petems commented Apr 22, 2014

This fixes #235 in a more permanent way 👍

This fixes boxen#235 in a more permanent way
@petems petems mentioned this pull request Apr 22, 2014
@tarebyte
Copy link
Member

tarebyte commented Jun 4, 2014

it looks fine to me @fromonesrc or @skottler second thumbs up?

@skottler
Copy link

skottler commented Jun 4, 2014

Messages like Fake group already exists - No action required are not going to mean anything to the average person running boxen. There doesn't need to be a message at all if nothing changes (to match boxen's current behavior) and the message for when something does change needs to be more descriptive of the change which actually occurred IMHO.

@petems
Copy link
Member Author

petems commented Jun 4, 2014

Ok, will change! 👍

Also changed to boxen standard of "No message if nothing changes"
@petems
Copy link
Member Author

petems commented Jun 18, 2014

@skottler I've made the changes you asked for, look good? 👍

@petems
Copy link
Member Author

petems commented Jun 23, 2014

@fromonesrc @skottler any thoughts? 👍

@giladgo
Copy link

giladgo commented Aug 11, 2014

Hey,
Just tried using this PR by applying it independently. It works great!
However, running it the first time, I got a 'syntax error', because the then part was empty. My knowledge in shell scripting is rather limited, so all I did was to restore the echo, and it worked. I guess an if-not statement should probably be more appropriate.

GID=`id -g`
USERNAME=`id -u -nr`

if grep $GID /etc/group >/dev/null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just negate the condition, since you've got an empty then clause

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 👍

@petems
Copy link
Member Author

petems commented Sep 26, 2014

@dgoodlad made the changes, it's no longer automatic. Can you merge? 👍

@petems
Copy link
Member Author

petems commented Dec 11, 2014

@dgoodlad poke

Conflicts:
	script/bootstrap
@petems
Copy link
Member Author

petems commented Dec 21, 2014

@dgoodlad ping! 😄

dgoodlad added a commit that referenced this pull request Dec 21, 2014
Add a script to create a fake group
@dgoodlad dgoodlad merged commit 0ce388d into boxen:master Dec 21, 2014
@dgoodlad
Copy link
Contributor

Pong! 😁

@petems
Copy link
Member Author

petems commented Dec 21, 2014

Ty! 💃

@petems petems deleted the fix_gid_issue branch December 21, 2014 01:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Invalid group error
5 participants