Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Having node_modules/bin on PATH breaks find -execdir #47

Closed
mavant opened this issue Apr 1, 2015 · 2 comments
Closed

Having node_modules/bin on PATH breaks find -execdir #47

mavant opened this issue Apr 1, 2015 · 2 comments

Comments

@mavant
Copy link

mavant commented Apr 1, 2015

find: The relative path `node_modules/bin' is included in the PATH environment variable, which is insecure in combination with the -execdir action of find.  Please remove that entry from $PATH

This warning is only emitted by GNU find, not BSD find, but it's a problem for both.

This is a significant problem since, as per issue #45, there's no obvious way to just remove nodejs from my boxen config. I don't need nodejs, and if I do I can install it some other, less broken way, but I DO need find.

@mavant
Copy link
Author

mavant commented Apr 1, 2015

Having a hiera option similar to boxen::environment::relative_bin_on_path would solve the problem, although I'd still argue that this should be false by default.

mavant added a commit to mavant/our-boxen that referenced this issue Apr 2, 2015
@blackjid
Copy link
Member

The node_modules/bin on the PATH was removed in the latest release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants