Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/network switch #26

Merged
merged 21 commits into from
Aug 1, 2022
Merged

feat/network switch #26

merged 21 commits into from
Aug 1, 2022

Conversation

aspnxdd
Copy link
Contributor

@aspnxdd aspnxdd commented Jul 28, 2022 •
edited

Fixes #

Changes

  • Adds a network switcher. By default it selects Devnet.

Checks

  • Have you catchup your branch with the latest state in base?
  • Have you lint your code locally prior to submission?
  • Have you reviewed your proposed changes and removed debris?
  • Have you successfully ran due tests with your changes?

@boxfish-bot boxfish-bot temporarily deployed to Preview July 28, 2022 08:15 Inactive
@boxfish-bot boxfish-bot temporarily deployed to Preview July 28, 2022 08:19 Inactive
@boxfish-bot boxfish-bot temporarily deployed to Preview July 28, 2022 09:42 Inactive
@boxfish-bot boxfish-bot temporarily deployed to Preview July 28, 2022 11:01 Inactive
@boxfish-bot boxfish-bot temporarily deployed to Preview July 28, 2022 11:05 Inactive
agus-xyz
agus-xyz reviewed Jul 28, 2022
View reviewed changes
Copy link
Member

@agus-xyz agus-xyz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good!
only 2 remarks.
It seems like some tokens are shown repeated in the same table. For example, in the mainnet cluster, the 2 first tokens are the same. Why does this happen? Is the token both, configuration and mongo db?

image

Then, on the other hand, I also noticed that some tokens are available in both mainnet and devnet (like 7Ekb395BZSq3jyshLo5rtcJSoxPtCYq7N3owh3rB3F2q). Is that correct? Is the token available in both clusters?

image
image

@boxfish-bot boxfish-bot temporarily deployed to Preview July 28, 2022 11:18 Inactive
@agus-xyz
Copy link
Member

could it be that the top bar of the table broke a bit?
image

@boxfish-bot boxfish-bot temporarily deployed to Preview July 28, 2022 13:16 Inactive
@boxfish-bot
Copy link
Member

This pull request has been deployed to Vercel.

Latest commit: a5c1710
✅ Preview: https://fontana-noo9qe6st-boxfish-studio.vercel.app
🔍 Inspect: https://vercel.com/boxfish-studio/fontana/B6waxtGLPYodhZWAnJaHoBCLijM4

View Workflow Logs

@aspnxdd aspnxdd requested a review from agus-xyz July 28, 2022 13:48
agus-xyz
agus-xyz approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@agus-xyz agus-xyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

@agus-xyz agus-xyz merged commit 77ccee7 into main Aug 1, 2022
@agus-xyz agus-xyz deleted the feat/network-switch branch August 1, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agus-xyz agus-xyz agus-xyz approved these changes

@begonaalvarezd begonaalvarezd Awaiting requested review from begonaalvarezd

Assignees
No one assigned
Labels
deployed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aspnxdd @agus-xyz @boxfish-bot