Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add footer component #124

Merged
merged 3 commits into from
Jul 13, 2022
Merged

feat: add footer component #124

merged 3 commits into from
Jul 13, 2022

Conversation

evavirseda
Copy link
Member

Fixes #89

Changes

  • Add footer component, use Primer CSS and follow the figma design

Checks

  • Have you catchup your branch with the latest state in base?
  • Have you lint your code locally prior to submission?
  • Have you reviewed your proposed changes and removed debris?
  • Have you successfully ran due tests with your changes?

@evavirseda evavirseda requested review from VmMad and cpl121 July 12, 2022 13:55
@boxfish-bot boxfish-bot temporarily deployed to Preview July 12, 2022 13:56 Inactive
VmMad
VmMad approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cpl121
cpl121 reviewed Jul 13, 2022
View reviewed changes
components/Footer.tsx Outdated Show resolved Hide resolved
@boxfish-bot boxfish-bot temporarily deployed to Preview July 13, 2022 08:57 Inactive
@boxfish-bot boxfish-bot temporarily deployed to Preview July 13, 2022 09:11 Inactive
@boxfish-bot
Copy link
Member

This pull request has been deployed to Vercel.

Latest commit: bacc708
✅ Preview: https://candy-machine-dashboard-k9ls6lsyl-boxfish-studio.vercel.app
🔍 Inspect: https://vercel.com/boxfish-studio/candy-machine-dashboard/ChFSnVi37QVQ4cDfgbqnnuRwExQN

View Workflow Logs

cpl121
cpl121 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@cpl121 cpl121 merged commit a645a5f into dev Jul 13, 2022
@cpl121 cpl121 deleted the feat/add-footer branch July 13, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VmMad VmMad VmMad approved these changes

@cpl121 cpl121 cpl121 approved these changes

Assignees
No one assigned
Labels
deployed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Update footer to new design system
4 participants
@evavirseda @boxfish-bot @VmMad @cpl121