Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add version in footer #141

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Feat: Add version in footer #141

merged 1 commit into from
Jul 19, 2022

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Jul 18, 2022

Fixes #115

Changes

  • Update build command in package.json
  • On app build, fetch project latest tag and generate version file (untracked in git)
  • Display version in footer

Checks

  • Have you catchup your branch with the latest state in base?
  • Have you lint your code locally prior to submission?
  • Have you reviewed your proposed changes and removed debris?
  • Have you successfully ran due tests with your changes?

@cpl121 cpl121 requested review from evavirseda and VmMad July 18, 2022 16:26
@boxfish-bot boxfish-bot temporarily deployed to Preview July 18, 2022 16:26 Inactive
@boxfish-bot
Copy link
Member

This pull request has been deployed to Vercel.

Latest commit: 6530a36
✅ Preview: https://candy-machine-dashboard-jgn3l8abg-boxfish-studio.vercel.app
🔍 Inspect: https://vercel.com/boxfish-studio/candy-machine-dashboard/3LUe6MJ8VkS2PnX8umPGRQXMh3GU

View Workflow Logs

VmMad
VmMad approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

evavirseda
evavirseda approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@cpl121 cpl121 merged commit 5bc2f20 into dev Jul 19, 2022
@cpl121 cpl121 deleted the feat/add-tag-version-in-footer branch July 19, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda approved these changes

@VmMad VmMad VmMad approved these changes

Assignees
No one assigned
Labels
deployed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add deployed version number to footer
4 participants
@cpl121 @boxfish-bot @evavirseda @VmMad