Feat: upload delete popup #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dio/sugar-rush into feat/refactor-reusable-popup
…-popup' of github.com:boxfish-studio/candy-machine-dashboard into feat/upload-delete-popup
evavirseda
requested changes
Jul 20, 2022
| } | ||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
Suggested change
| <> | |
| <div className='d-flex flex-column flex-justify-between'> | |
| <div> | |
| <Text as='p'>Are you sure you want to delete candy machine</Text> | |
| <Text as='p' className='wb-break-all'>{candyMachineAccount}</Text> |
components/Popup.tsx
Outdated
| height: '100%', | ||
| maxHeight: size === 'large' ? ['550px', '750px'] : ['50%'], | ||
| maxHeight: size === 'large' ? ['550px', '750px'] : ['27.5%'], |
There was a problem hiding this comment.
Suggested change
| maxHeight: size === 'large' ? ['550px', '750px'] : ['27.5%'], | |
| maxHeight: size === 'large' ? ['550px', '750px'] : ['40%', '27.5%'], |
components/DeleteCandyMachine.tsx
Outdated
| <> | ||
| <div style={{ display: 'grid', gridRowGap: '5px' }}> | ||
| <Text as='p'>Are you sure you want to delete candy machine {candyMachineAccount}</Text> | ||
| {!isDeleting && status.message && ( |
…rd into feat/upload-delete-popup
|
|
Yes, this is solved in this pr because the behavior is similar |
…fish-studio/candy-machine-dashboard into feat/upload-delete-popup
|
please @cpl121 lets fix the conflicts with the base branch before proceeding with a final review 🙏🏼 |
…fish-studio/candy-machine-dashboard into feat/upload-delete-popup
|
This pull request has been deployed to Vercel.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110
Changes
Checks