Feat/fetch cm from wallet and update cm #15

aspnxdd · 2022-05-10T15:41:57Z

This PR includes:

Fetch the Candy Machines accounts from the connected wallet
Retrieve the config on-chain from the connected wallet
Update some config from the candy machine on-chain
Transfer authority of the given candy machine to another wallet

Closes #9, #8

Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio>

…te-cm

cpl121 · 2022-05-10T16:40:51Z

components/CreateCM/Form.tsx

-    storage: '',
-    files: [],
-  } as const;
+  function isFormUpdateIsValid(): boolean {


Double "is" is redundant, i think isFormUpdateValid is better

cpl121 · 2022-05-12T08:28:21Z

hooks/useUploadCache.tsx

+    Array.from(e.target.files).forEach((file) => {
+      fileList.push(file);
+    });
+    setCache(fileList[0]);


If only the first value of the array is necessary, why is the whole array iterated?

cpl121 · 2022-05-12T08:37:35Z

components/CreateCM/Form.tsx

+
+  const { files, uploadAssets } = useUploadFiles();
+  const { cache, uploadCache } = useUploadCache();
+  const [interactingWithCM, setInteractingWithCM] = useState(false);


This state stores a boolean, i think it's better that the name starts with is isInteractingWithCM

cpl121 · 2022-05-12T08:46:05Z

lib/candy-machine/types.ts

+  solTreasuryAccount: PublicKey;
+  itemsRedeemed: BN;
+}
+
 export interface CandyMachineConfig {


Suggestion! I was checking firefly best practices page, and they name the interfaces with a capital "i" at the beginning. In this case it would be ICandyMachineConfig
If you see it correct, we could implement it for all interfaces

https://iotaledger.github.io/firefly/guides/coding-conventions/naming/

I personally prefer not using prefixes or suffixes for types/interfaces

cpl121 · 2022-05-12T09:21:26Z

pages/list-candy-machines/[id].tsx

+      </Head>
+      <div className='flex justify-center items-center flex-col'>
+        <Title text='Update Candy Machine' />
+        <span className='mt-8'>{account}{" "}<a className='text-blue-700' href={`https://solscan.io/account/${account}?cluster=devnet`}>View in Solscan</a></span>


I think its better that the link is opened in another tab

<a className='text-blue-700' href={"https://solscan.io/account/${account}?cluster=devnet"} target="_blank" rel="noopener noreferrer">View in Solscan</a>

Totally agree.

cpl121 · 2022-05-12T09:58:41Z

lib/candy-machine/utils.ts

@@ -0,0 +1,84 @@
+import { BN } from '@project-serum/anchor';
+


We can use moment.js to do many of the date functions

cpl121 · 2022-05-12T09:59:42Z

lib/candy-machine/utils.ts

+ * @param time time to parse
+ * @returns {string} time parsed to UCT
+ */
+export function parseDateToUTC(dateTime: string, time: string): string {


Moment has a function for this moment.utc

cpl121 · 2022-05-12T10:00:29Z

lib/candy-machine/utils.ts

+  return `${hours}:${minutes}`;
+}
+
+export function getCurrentTime() {


Moment has a function for this moment().format('LT')

There are 2 reasons why I created these functions manually:

Reduce size of the project, since we are only using 5 silly functions to parse dates, I decided to just write them up myself. We are not doing heavy date manipulation, therefore I consider it is not needed.

All these functions (moment.utc() and moment().format('LT')) do not provide the desired outcome: if the date is "8:00", the desired outcome should be "08:00".
According to the momentjs docs here the format("LT") provides "8:30 PM" but we would only need "08:30" (0 at the start and remove AM/PM).
For the UTC we need "2 May 2021 08:00:00 GMT", but the moment.utc() provides "2013-02-04T18:35:24+00:00" for example.
In this case I think we would not obtain any benefit by using moment.js

cpl121 · 2022-05-12T10:12:21Z

pages/list-candy-machines/[id].tsx

+  const { connection } = useConnection();
+  const [candyMachineConfig, setCandyMachineConfig] =
+    useState<FetchedCandyMachineConfig>();
+  const [loading, setLoading] = useState({ loading: false, error: false });


I think this state checks if the loading spinner is shown, or an error has to be shown
If it does this, I think const [spinner, setSpinner] = useState({ loading: false, error: false }); better explains what this state does

cpl121 · 2022-05-12T10:13:51Z

pages/list-candy-machines/[id].tsx

+            View in Solscan
+          </a>
+        </span>
+        {loading.loading && <Spinner />}


I have commented the previous comment because this does not give me much information - loading.loading

cpl121 · 2022-05-12T10:15:12Z

pages/list-candy-machines/index.tsx

+          CANDY_MACHINE_PROGRAM_V2_ID,
+          {
+            commitment: 'confirmed',
+


This space is not necessary

…rd into feat/fetch-cm-from-wallet-and-update-cm

cpl121

Nice job!

aspnxdd and others added 30 commits May 4, 2022 11:45

wallets providers + layout

2342d6e

add cm functions + update form component

67cf246

config cmv2 + verify assets

f1496f0

commit new changes

1093997

Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio>

Create Candy Machine Acc

f74b541

arweave upload

d84722f

upload cm arweave

fa4e92c

add prettier

0b6ac17

create types file and organize code

6cbdfcf

add typing

4a2def7

fetch candy machines from a wallet address

ba0b412

form pre-filled

703cb8f

Merge branch 'dev' into feat/upload-cm

8d42057

fix merge

f2d08eb

update cm

6528ecd

fixes

e0156c0

fix form

8771a35

Merge branch 'feat/upload-cm' into feat/fetch-cm-from-wallet

d18f03f

fix utils parse date functions

1144dbf

fixes

5fb84fb

Merge branch 'feat/upload-cm' into feat/fetch-cm-from-wallet

ce9b89c

update authority

2587b1f

default values for date and time

99eb813

-

4e2a233

.

7f6a5b0

-

d4ad52d

fix files location

b4aa759

Feat: add spinner and error message display

a560abc

-

ca7d75b

Feat: add items available and redeemed

ba880b1

aspnxdd added 5 commits May 10, 2022 12:04

rename ms to millseconds

b45e217

Merge branch 'feat/upload-cm' into feat/fetch-cm-from-wallet-and-upda…

cffba1d

…te-cm

Feat: add reactive button when submitting form

128ad12

Feat: add search bar to filter cm list

9cccfc9

Fix: remove consolelogs

142c4c7

aspnxdd requested review from begonaalvarezd and cpl121 May 10, 2022 15:42

begonaalvarezd changed the base branch from dev to feat/upload-cm May 10, 2022 16:11

cpl121 reviewed May 10, 2022

View reviewed changes

Fix: change isFormUpdateValid name

94198ac

cpl121 reviewed May 12, 2022

View reviewed changes

Fix: rename useState and remove loop in useUploadCache

e5e1ffc

cpl121 reviewed May 12, 2022

View reviewed changes

Fix: make solscan link open in a new tab

df1053c

cpl121 reviewed May 12, 2022

View reviewed changes

pages/list-candy-machines/index.tsx Outdated

CANDY_MACHINE_PROGRAM_V2_ID,

{

commitment: 'confirmed',

Copy link

Member

cpl121 May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This space is not necessary

remove space

b21cbc6

Base automatically changed from feat/upload-cm to dev May 12, 2022 13:37

aspnxdd added 4 commits May 12, 2022 16:41

Merge branch 'dev' into feat/fetch-cm-from-wallet-and-update-cm

e35eb11

Merge branch 'dev' of github.com:boxfish-studio/candy-machine-dashboa…

c0f455f

…rd into feat/fetch-cm-from-wallet-and-update-cm

Fix: add connected wallet

8c72dbb

Fix: check wallet is connected

ae906fd

cpl121 approved these changes May 17, 2022

View reviewed changes

cpl121 merged commit d990283 into dev May 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/fetch cm from wallet and update cm #15

Feat/fetch cm from wallet and update cm #15

aspnxdd commented May 10, 2022 •

edited

cpl121 May 10, 2022

cpl121 May 12, 2022

cpl121 May 12, 2022

cpl121 May 12, 2022

aspnxdd May 12, 2022

cpl121 May 12, 2022 •

edited

aspnxdd May 12, 2022

cpl121 May 12, 2022

cpl121 May 12, 2022

cpl121 May 12, 2022

aspnxdd May 12, 2022

cpl121 May 12, 2022

cpl121 May 12, 2022

cpl121 May 12, 2022

cpl121 May 12, 2022

cpl121 left a comment

Feat/fetch cm from wallet and update cm #15

Feat/fetch cm from wallet and update cm #15

Conversation

aspnxdd commented May 10, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cpl121 May 12, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cpl121 left a comment

Choose a reason for hiding this comment

aspnxdd commented May 10, 2022 •

edited

cpl121 May 12, 2022 •

edited