Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug with network switching #153

Merged
merged 1 commit into from
Jul 21, 2022
Merged

fix: bug with network switching #153

merged 1 commit into from
Jul 21, 2022

Conversation

aspnxdd
Copy link
Contributor

@aspnxdd aspnxdd commented Jul 21, 2022

Fixes #

Changes

  • Fixes bug where initial load caused an error throw

Checks

  • Have you catchup your branch with the latest state in base?
  • Have you lint your code locally prior to submission?
  • Have you reviewed your proposed changes and removed debris?
  • Have you successfully ran due tests with your changes?

@boxfish-bot boxfish-bot temporarily deployed to Preview July 21, 2022 10:40 Inactive
@boxfish-bot
Copy link
Member

This pull request has been deployed to Vercel.

Latest commit: 18560dd
✅ Preview: https://candy-machine-dashboard-fy64ha6a3-boxfish-studio.vercel.app
🔍 Inspect: https://vercel.com/boxfish-studio/candy-machine-dashboard/3rQYtBg1LD5HMNDP2mi2yDNhctJY

View Workflow Logs

@agus-xyz agus-xyz merged commit ef3cc5e into dev Jul 21, 2022
@agus-xyz agus-xyz deleted the fix/network-switch-bug branch July 21, 2022 10:44
if (candyMachineAccount && anchorWallet) {
try {
console.log(4, error)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing console.log

}, [candyMachineAccount, connection, anchorWallet])
;(async function () {
setError('')
fetchCandyMachine().then(setCandyMachineConfig)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be a good idea to include .catch here?

retainAuthority: state.data.retainAuthority,
},
})
} catch (_) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better if this catch contained something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants