Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Errors to create candy machine #166

Merged
merged 3 commits into from
Jul 22, 2022
Merged

Fix: Errors to create candy machine #166

merged 3 commits into from
Jul 22, 2022

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Jul 22, 2022

Fixes #165

Changes

  • Show error card instead of Candy Machine created successfully! when error occurs
  • Show error when no connection
  • Fix console error to open create cm popup

@cpl121 cpl121 requested a review from evavirseda July 22, 2022 08:45
@cpl121 cpl121 changed the base branch from main to dev July 22, 2022 08:45
evavirseda
evavirseda approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@cpl121 cpl121 merged commit c6c1222 into dev Jul 22, 2022
@cpl121 cpl121 deleted the fix/errors-to-create-candy-machine branch July 22, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix]: Errors to create candy machine
2 participants
@cpl121 @evavirseda