Fix: first manifest must be 0.json #18

aspnxdd · 2022-05-12T15:40:44Z

This PR fixes the following:

Depending on the order of uploading files, the CM creation failed. Now, it makes sure that the firstManifest is the 0.json file, therefore the upload order does not matter.

cpl121 · 2022-05-12T15:47:35Z

lib/candy-machine/upload/upload.ts

+      const firstManifestFile = files.find((file) => file.name === "0.json");
+      if (!firstManifestFile) throw new Error("0.json must be present")


Better to use single quotes

cpl121

Perfect!

Fix: first manifest must be 0.json

98ca56c

aspnxdd requested review from begonaalvarezd and cpl121 May 12, 2022 15:40

cpl121 reviewed May 12, 2022

View reviewed changes

Fix: run prettier

6243aab

aspnxdd requested a review from cpl121 May 12, 2022 15:53

cpl121 approved these changes May 12, 2022

View reviewed changes

cpl121 merged commit 2fccdfc into dev May 17, 2022

begonaalvarezd deleted the fix/create-cm-first-json-0 branch May 17, 2022 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: first manifest must be 0.json #18

Fix: first manifest must be 0.json #18

aspnxdd commented May 12, 2022

cpl121 May 12, 2022

cpl121 left a comment

		const firstManifestFile = files.find((file) => file.name === "0.json");
		if (!firstManifestFile) throw new Error("0.json must be present")

Fix: first manifest must be 0.json #18

Fix: first manifest must be 0.json #18

Conversation

aspnxdd commented May 12, 2022

cpl121 May 12, 2022

Choose a reason for hiding this comment

cpl121 left a comment

Choose a reason for hiding this comment