Skip to content

Commit

Permalink
Fix invalid URL issue
Browse files Browse the repository at this point in the history
  • Loading branch information
boxuancui committed Jan 24, 2024
1 parent da4a828 commit 5c0fc3d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 13 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ report_files/
^pkgdown$
^CODE_OF_CONDUCT\.md$
^code_of_conduct\.md$
^CRAN-SUBMISSION$
2 changes: 1 addition & 1 deletion README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ knitr::opts_chunk$set(
[![Total Downloads](http://cranlogs.r-pkg.org/badges/grand-total/DataExplorer)](https://cran.r-project.org/package=DataExplorer)
[![GitHub Stars](https://img.shields.io/github/stars/boxuancui/DataExplorer.svg?style=social)](https://github.com/boxuancui/DataExplorer)
[![R-CMD-check](https://github.com/boxuancui/DataExplorer/actions/workflows/check-standard.yaml/badge.svg)](https://github.com/boxuancui/DataExplorer/actions/workflows/check-standard.yaml)
[![codecov](https://codecov.io/gh/boxuancui/DataExplorer/graph/badge.svg?token=w8eMGjF8Jw)](https://codecov.io/gh/boxuancui/DataExplorer)
[![codecov](https://codecov.io/gh/boxuancui/DataExplorer/graph/badge.svg?token=w8eMGjF8Jw)](https://app.codecov.io/gh/boxuancui/DataExplorer)
[![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/2053/badge)](https://bestpractices.coreinfrastructure.org/projects/2053)
[![Contributor Covenant](https://img.shields.io/badge/Contributor%20Covenant-2.1-4baaaa.svg)](http://boxuancui.github.io/DataExplorer/code_of_conduct.html)

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Downloads](http://cranlogs.r-pkg.org/badges/grand-total/DataExplorer)](https://c
[![GitHub
Stars](https://img.shields.io/github/stars/boxuancui/DataExplorer.svg?style=social)](https://github.com/boxuancui/DataExplorer)
[![R-CMD-check](https://github.com/boxuancui/DataExplorer/actions/workflows/check-standard.yaml/badge.svg)](https://github.com/boxuancui/DataExplorer/actions/workflows/check-standard.yaml)
[![codecov](https://codecov.io/gh/boxuancui/DataExplorer/graph/badge.svg?token=w8eMGjF8Jw)](https://codecov.io/gh/boxuancui/DataExplorer)
[![codecov](https://codecov.io/gh/boxuancui/DataExplorer/graph/badge.svg?token=w8eMGjF8Jw)](https://app.codecov.io/gh/boxuancui/DataExplorer)
[![CII Best
Practices](https://bestpractices.coreinfrastructure.org/projects/2053/badge)](https://bestpractices.coreinfrastructure.org/projects/2053)
[![Contributor
Expand Down
13 changes: 2 additions & 11 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,7 @@ I have addressed the 2 NOTES in the Check Results page, i.e.,
* Missing `obj` definition
* `LazyData` is specified without a `data` directory

In addition, I am getting the following warning regarding Codecov.io. I copied them directly from the official page and tested them. My original URL is working fine and the suggested badge URL is not working. I am not sure what the problem is, so please advise on how to address it.

```
! Warning: README.md:12:13 Moved
[![codecov](https://codecov.io/gh/boxuancui/DataExplorer/graph/badge.svg?token=w8eMGjF8Jw)](https://codecov.io/gh/boxuancui/DataExplorer)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
https://app.codecov.io/gh/boxuancui/DataExplorer
```
In addition, I have fixed the invalid URL note from the previous submission.

## Test environments
GitHub Actions:
Expand All @@ -26,8 +19,6 @@ GitHub Actions:

## R CMD check results

The only outstanding note is what I described above.

❯ checking CRAN incoming feasibility ... [6s/49s] NOTE Maintainer: ‘Boxuan Cui <boxuancui@gmail.com> Found the following (possibly) invalid URLs: URL: https://codecov.io/gh/boxuancui/DataExplorer (moved to https://app.codecov.io/gh/boxuancui/DataExplorer) From: README.md Status: 200 Message: OK 0 errors ✔ | 0 warnings ✔ | 1 note ✖
0 errors ✔ | 0 warnings ✔ | 0 notes ✔

## revdepcheck resultsWe checked 1 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. * We saw 0 new problems * We failed to check 0 packages
Expand Down

0 comments on commit 5c0fc3d

Please sign in to comment.