-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to UI SDK for SSO #2299
Switch to UI SDK for SSO #2299
Conversation
…into sso-list-sdk-usage
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
What does this PR do?
Use ConnectionList and DirectoryList components from SDK. This comes on the back of Pagination support inside SDK for rendering the list. To be tested with boxyhq/ui#806. Pagination is only enabled in the main SSO connections and DIrectory Sync routes. Other routes like Setup links/Settings connections should render without paginating.
Type of change
How should this be tested?
This change needs to be tested with SSO, DSync connections under Admin portal plus the list under Setup links/Settings (non paginated).
Also Pagination needs to be tested with dynamoDB (token based pagination) and other DBs.
Checklist: