Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to UI SDK for SSO #2299

Merged
merged 20 commits into from
Feb 22, 2024
Merged

Switch to UI SDK for SSO #2299

merged 20 commits into from
Feb 22, 2024

Conversation

niwsa
Copy link
Member

@niwsa niwsa commented Feb 13, 2024

What does this PR do?

Use ConnectionList and DirectoryList components from SDK. This comes on the back of Pagination support inside SDK for rendering the list. To be tested with boxyhq/ui#806. Pagination is only enabled in the main SSO connections and DIrectory Sync routes. Other routes like Setup links/Settings connections should render without paginating.

Type of change

  • Updated dependencies
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

This change needs to be tested with SSO, DSync connections under Admin portal plus the list under Setup links/Settings (non paginated).

Also Pagination needs to be tested with dynamoDB (token based pagination) and other DBs.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

socket-security bot commented Feb 21, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@aws-sdk/client-dynamodb@3.518.0 Transitive: environment, filesystem, network, shell +81 6.57 MB amzn-oss, aws-sdk-bot, kuhe, ...2 more
npm/@aws-sdk/util-dynamodb@3.518.0 Transitive: environment, filesystem, network, shell +82 6.62 MB amzn-oss, aws-sdk-bot, kuhe, ...2 more
npm/@boxyhq/react-ui@3.3.37 None 0 1.09 MB aswin_boxyhq, deepakp, kiranboxyhq, ...1 more
npm/@boxyhq/saml20@1.4.12 Transitive: filesystem +12 6.48 MB aswin_boxyhq, deepakp, kiranboxyhq, ...1 more
npm/@types/node@20.11.19 None +1 4.07 MB types
npm/migrate-mongo@11.0.0 filesystem Transitive: environment, network, shell +113 20.6 MB seppevs
npm/mixpanel@0.18.0 environment, network +3 143 kB tdumitrescu
npm/mongodb@6.3.0 environment, filesystem, network, shell +94 11.7 MB dbx-node
npm/mssql@10.0.2 Transitive: environment, eval, filesystem, network, shell +135 35.8 MB dhensby
npm/mysql2@3.9.1 environment, network Transitive: eval +11 1.98 MB sidorares
npm/nock@13.5.3 environment, filesystem, network +4 260 kB nockbot
npm/node-forge@1.3.1 None 0 1.66 MB davidlehn
npm/openid-client@5.6.4 network +5 780 kB panva
npm/pg@8.11.3 environment, network Transitive: filesystem +15 480 kB brianc
npm/redis@4.6.13 Transitive: network +9 974 kB leibale
npm/reflect-metadata@0.2.1 None 0 241 kB rbuckton
npm/ripemd160@2.0.2 Transitive: environment +6 196 kB dcousens
npm/sinon@17.0.1 Transitive: environment, eval +12 7.33 MB fatso83
npm/tap@18.7.0 Transitive: environment, filesystem, network, shell, unsafe +296 102 MB isaacs
npm/ts-node@10.9.2 environment, filesystem, unsafe +19 38.1 MB blakeembrey
npm/tsconfig-paths@4.2.0 environment, filesystem, unsafe +3 509 kB jonaskello
npm/typeorm@0.3.20 environment, eval, filesystem Transitive: network, shell, unsafe +343 112 MB pleerock
npm/typescript@5.3.3 None 0 32 MB typescript-bot
npm/xmlbuilder@15.1.1 None 0 321 kB oozcitak

🚮 Removed packages: npm/@boxyhq/react-ui@3.3.36, npm/@tailwindcss/typography@0.5.10, npm/@types/cors@2.8.17, npm/@types/micromatch@4.0.6, npm/@types/node@20.10.1, npm/@types/react@18.2.57, npm/@typescript-eslint/eslint-plugin@7.0.2, npm/@typescript-eslint/parser@7.0.2, npm/autoprefixer@10.4.17, npm/blockly@10.4.1, npm/chroma-js@2.4.2, npm/classnames@2.5.1, npm/cors@2.8.5, npm/daisyui@4.7.2, npm/env-cmd@10.1.0, npm/eslint-config-next@14.1.0, npm/eslint-config-prettier@9.1.0, npm/eslint-plugin-i18next@6.0.3, npm/eslint@8.56.0, npm/i18next@22.5.1

View full report↗︎

Copy link

socket-security bot commented Feb 21, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/protobufjs@7.2.6
  • Install script: postinstall
  • Source: node scripts/postinstall

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/protobufjs@7.2.6

@niwsa niwsa marked this pull request as ready for review February 21, 2024 17:39
@niwsa niwsa requested a review from a team February 21, 2024 17:39
@niwsa niwsa merged commit b54463e into main Feb 22, 2024
5 of 6 checks passed
@niwsa niwsa deleted the sso-list-sdk-usage branch February 22, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants