Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added e2e tests for enterprise SSO setup link #2728

Merged
merged 4 commits into from
May 27, 2024

Conversation

nitendra-new
Copy link
Contributor

generic SAML 2.0 workflow

What does this PR do?

Fixes # (issue)

Type of change

  • Updated dependencies
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Existing unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nitendra-new nitendra-new force-pushed the setup-links-e2e-tests branch 7 times, most recently from 1fa75da to e5db902 Compare May 22, 2024 13:36
e2e/ui/Enterprise SSO/setup_link.spec.ts Outdated Show resolved Hide resolved
e2e/ui/Enterprise SSO/setup_link.spec.ts Outdated Show resolved Hide resolved
e2e/ui/Enterprise SSO/setup_link.spec.ts Outdated Show resolved Hide resolved
 - Refactored code to remove localor.all
 - removed extract awaits like page repload
e2e/ui/Enterprise SSO/setup_link.spec.ts Outdated Show resolved Hide resolved
 - used fixtures to create setup link
 - removed unnecessary code
@deepakprabhakara deepakprabhakara merged commit 73b1337 into main May 27, 2024
5 of 6 checks passed
@deepakprabhakara deepakprabhakara deleted the setup-links-e2e-tests branch May 27, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants