New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: darkmode breaks on some places #1042

Merged

deepakprabhakara merged 93 commits into boxyhq:main from saqibtanveer786:fix/darkmode

Apr 13, 2024

Contributor

saqibtanveer786 commented Feb 18, 2024

This PR fixes the issue #1011

The dark mode was not working on some places like in dropdown, navigation etc. This PR tends to fix that.


          fix:Fixed the dark mode

9b4fee4

vercel bot commented Feb 18, 2024 •

edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
saas-starter-kit	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 13, 2024 7:05am

vercel bot deployed to Preview

February 18, 2024 06:43

View deployment

deepakprabhakara requested a review from devkiran

February 19, 2024 12:00

Member

deepakprabhakara commented Feb 19, 2024

Thanks @saqibtanveer786, we'll review this soon.

Contributor

devkiran commented Feb 20, 2024

@saqibtanveer786 Can you please take a look at sidebar items?

devkiran suggested changes

View reviewed changes

Contributor

devkiran left a comment

Please check my comment. There is an issue with sidebar item.

ukrocks007 and others added 23 commits

March 11, 2024 10:56


          Stripe version upgrade (boxyhq#1043)

bff12c6


          build(deps-dev): bump release-it from 17.0.5 to 17.1.1 (boxyhq#1045)

4b4d784

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps-dev): bump @types/react from 18.2.55 to 18.2.56 (boxyhq#1044)

602457e

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps-dev): bump @types/react from 18.2.56 to 18.2.57 (boxyhq#1048)

4ca6b14

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps-dev): bump @typescript-eslint/parser from 7.0.1 to 7.0.2 (b…

a9cb0ab

…oxyhq#1047)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps-dev): bump @typescript-eslint/eslint-plugin from 7.0.1 to …

0aa0152

…7.0.2 (boxyhq#1046)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump @sentry/nextjs from 7.101.1 to 7.102.0 (boxyhq#1049)

2e1ac86

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump svix from 1.18.0 to 1.19.0 (boxyhq#1050)

ff8e69a

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps-dev): bump prisma from 5.9.1 to 5.10.1 (boxyhq#1051)

192869b

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump @prisma/client from 5.9.1 to 5.10.1 (boxyhq#1052)

4da0475

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          added missing strings (boxyhq#1053)

bc9970a


          build(deps): bump @prisma/client from 5.10.1 to 5.10.2 (boxyhq#1057)

7b2f8bf

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps-dev): bump prisma from 5.10.1 to 5.10.2 (boxyhq#1056)

f6e0902

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump @boxyhq/react-ui from 3.3.36 to 3.3.37 (boxyhq#1055)

16c1d81

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump nodemailer from 6.9.9 to 6.9.10 (boxyhq#1054)

dccb3cf

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump @react-email/components from 0.0.14 to 0.0.15 (boxy…

f6a4018

…hq#1061)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump react-email from 2.0.0 to 2.1.0 (boxyhq#1060)

d733016

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump @sentry/nextjs from 7.102.0 to 7.102.1 (boxyhq#1059)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps-dev): bump @types/node from 20.11.19 to 20.11.20 (boxyhq#1058

f46d3c0

)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump sharp from 0.32.6 to 0.33.2 (boxyhq#910)

d3dc759

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps-dev): bump @types/react from 18.2.57 to 18.2.58 (boxyhq#1068)

93166e0

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump stripe from 14.17.0 to 14.18.0 (boxyhq#1067)

a1c1bb8

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump @boxyhq/saml-jackson from 1.18.9 to 1.19.1 (boxyhq#…

b4dd4a4

…1066)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

dependabot bot and others added 13 commits

March 11, 2024 10:59


          build(deps): bump yup from 1.3.3 to 1.4.0 (boxyhq#1111)

dfcf3ba

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps-dev): bump prettier-plugin-tailwindcss from 0.5.11 to 0.5.…

a1651a7

…12 (boxyhq#1110)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps-dev): bump @types/react from 18.2.63 to 18.2.64 (boxyhq#1109)

249541d

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump next from 14.1.2 to 14.1.3 (boxyhq#1108)

8f1bdb0

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps-dev): bump @types/node from 20.11.24 to 20.11.25 (boxyhq#1107

f3dd97a

)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump svix from 1.20.0 to 1.21.0 (boxyhq#1112)

0e44ab2

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps-dev): bump typescript from 5.3.3 to 5.4.2 (boxyhq#1113)

fd134d2

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump next-auth from 4.24.6 to 4.24.7 (boxyhq#1114)

089ee75

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps-dev): bump eslint-config-next from 14.1.2 to 14.1.3 (boxyh…

c35d893

…q#1115)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): bump @boxyhq/saml-jackson from 1.20.5 to 1.20.6 (boxyhq#…

d06188c

…1117)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          Release 1.3.4

db907d6


          build(deps): bump stripe from 14.19.0 to 14.20.0 (boxyhq#1119)

f39b239

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          Fix: NavItem not going well with hover

b1cd345

vercel bot had a problem deploying to Preview

March 11, 2024 06:02

Failure


          Fix: removed a useless console.log from Brand.tsx

a0dff3a

vercel bot deployed to Preview

March 11, 2024 06:06

View deployment


          Merge branch 'main' into fix/darkmode

Signed-off-by: Saqib Tanveer <116415769+saqibtanveer786@users.noreply.github.com>

vercel bot deployed to Preview

March 11, 2024 06:10

View deployment

Contributor Author

saqibtanveer786 commented Mar 11, 2024

now its working fine

i don't know why text-gray-100 not working but text-white got worked

deepakprabhakara requested a review from niwsa

March 14, 2024 16:03

ukrocks007 requested a review from a team

March 28, 2024 09:48


          Merge branch 'main' into fix/darkmode

35938a0

Signed-off-by: Saqib Tanveer <116415769+saqibtanveer786@users.noreply.github.com>

vercel bot deployed to Preview

March 29, 2024 10:36

View deployment

alexindris approved these changes

View reviewed changes


          Merge branch 'main' into fix/darkmode

Signed-off-by: Saqib Tanveer <116415769+saqibtanveer786@users.noreply.github.com>

vercel bot deployed to Preview

April 13, 2024 07:05

View deployment

deepakprabhakara approved these changes

View reviewed changes

Member

deepakprabhakara commented Apr 13, 2024

Many thanks @saqibtanveer786, LGTM.

deepakprabhakara merged commit 1b940aa into boxyhq:main

4 checks passed

deepakprabhakara mentioned this pull request

Fix dark mode #1011

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment