add transaction history pagination support #56
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem addressed
Some of the tastyworks endpoints need to be paginated. this PR adds pagination for the transactions (history) endpoint.
I refactored tastyworks/models/trading_account.py to save the session into the account object. It seemed cleaner to me. If you don't like it, I understand rejecting the PR. But feel free to use what I learned about history pagination in your own way.
Solution
Use HTTP GET request arguments "start-at", "end-at", "per-page", "page-offset"
Use HTTP GET response parameters "pagination" and "total-pages"
Checklist