Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

update dependencies and fix null error #154

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/main.yml
@@ -1,22 +1,25 @@
name: CI

on:
push
# manual workflow trigger
workflow_dispatch:
# matches every branch
push:
branches: "**"

jobs:
build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2

- uses: actions/setup-java@v1
with:
java-version: '12.x'
java-version: "12.x"
- uses: subosito/flutter-action@v1
with:
channel: 'master'
channel: "master"

- run: flutter config --enable-linux-desktop

Expand Down Expand Up @@ -50,4 +53,3 @@ jobs:

- name: Build APP
run: flutter build linux

2 changes: 1 addition & 1 deletion lib/media/tracks/tracks_player_impl_mobile.dart
Expand Up @@ -230,7 +230,7 @@ Future<Uint8List> _loadImageInterceptor(MusicMetadata metadata) async {
final ImageStream stream =
CachedImage(metadata.iconUri.toString()).resolve(ImageConfiguration(
size: const Size(150, 150),
devicePixelRatio: WidgetsBinding.instance.window.devicePixelRatio,
devicePixelRatio: WidgetsBinding.instance?.window.devicePixelRatio,
));
final image = Completer<ImageInfo>();
stream.addListener(ImageStreamListener((info, a) {
Expand Down
4 changes: 2 additions & 2 deletions lib/navigation/common/player/lyric.dart
Expand Up @@ -91,7 +91,7 @@ class LyricState extends State<Lyric> with TickerProviderStateMixin {
/// scroll lyric to current playing position
void _scrollToCurrentPosition(int? milliseconds, {bool animate = true}) {
if (lyricPainter!.height == -1) {
WidgetsBinding.instance.addPostFrameCallback((d) {
WidgetsBinding.instance?.addPostFrameCallback((d) {
// debugPrint("try to init scroll to position ${widget.position.value},"
// "but lyricPainter is unavaiable, so scroll(without animate) on next frame $d");
//TODO maybe cause bad performance
Expand Down Expand Up @@ -267,7 +267,7 @@ class _ScrollerListenerState extends State<_ScrollerListener> {
void _receivedPointerSignal(PointerSignalEvent event) {
if (event is PointerScrollEvent) {
if (_pointerSignalEventDelta(event) != 0.0) {
GestureBinding.instance.pointerSignalResolver
GestureBinding.instance!.pointerSignalResolver
.register(event, _handlePointerScroll);
}
}
Expand Down
2 changes: 1 addition & 1 deletion lib/navigation/desktop/widgets/windows_task_bar.dart
Expand Up @@ -33,7 +33,7 @@ class _WindowsTaskBar extends ConsumerWidget {
Widget build(BuildContext context, WidgetRef ref) {
ref.listen<TracksPlayerState>(playerStateProvider, (previous, next) {
if (next.playingTrack == null) {
WindowsTaskbar.clearThumbnailToolbar();
WindowsTaskbar.resetThumbnailToolbar();
} else {
WindowsTaskbar.setThumbnailToolbar([
ThumbnailToolbarButton(
Expand Down
4 changes: 2 additions & 2 deletions lib/navigation/mobile/home/main_page_my.dart
Expand Up @@ -150,7 +150,7 @@ class _MainPageMyState extends ConsumerState<MainPageMy>
curve: Curves.linear,
)
.then((_) {
WidgetsBinding.instance.scheduleFrameCallback((timeStamp) {
WidgetsBinding.instance?.scheduleFrameCallback((timeStamp) {
_scrollToPlayList(type);
});
});
Expand All @@ -162,7 +162,7 @@ class _MainPageMyState extends ConsumerState<MainPageMy>
curve: Curves.linear,
)
.then((_) {
WidgetsBinding.instance.scheduleFrameCallback((timeStamp) {
WidgetsBinding.instance?.scheduleFrameCallback((timeStamp) {
_scrollToPlayList(type);
});
});
Expand Down
2 changes: 1 addition & 1 deletion lib/navigation/mobile/player/page_playing.dart
Expand Up @@ -18,7 +18,7 @@ class PlayingPage extends ConsumerWidget {
Widget build(BuildContext context, WidgetRef ref) {
final current = ref.read(playerStateProvider).playingTrack;
if (current == null) {
WidgetsBinding.instance.scheduleFrameCallback((_) {
WidgetsBinding.instance?.scheduleFrameCallback((_) {
Navigator.of(context).pop();
});
return Container();
Expand Down