Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

update dependencies and fix null error #154

Closed
wants to merge 3 commits into from
Closed

update dependencies and fix null error #154

wants to merge 3 commits into from

Conversation

yzhe819
Copy link

@yzhe819 yzhe819 commented Feb 27, 2022

🛠 Fix following building error:

Error: Property 'window' cannot be accessed on 'WidgetsBinding?' because it is potentially null.
Try accessing using ?. instead.
devicePixelRatio: WidgetsBinding.instance.window.devicePixelRatio,

Error: Method 'scheduleFrameCallback' cannot be called on 'WidgetsBinding?' because it is potentially null.
Try calling using ?. instead.
WidgetsBinding.instance.scheduleFrameCallback((_) {

🛠 Fix following building error:

Error: Property 'window' cannot be accessed on 'WidgetsBinding?' because it is potentially null.

Error: Method 'scheduleFrameCallback' cannot be called on 'WidgetsBinding?' because it is potentially null.
remove unused '!'
remove deprecated method "clearThumbnailToolbar". Use [WindowsTaskbar.resetThumbnailToolbar] instead.
@yzhe819
Copy link
Author

yzhe819 commented Feb 28, 2022

尝试帮忙修复GitHub Actions中build显示的错误(挠头
以及添加了手动开启Github Action的配置

Flutter 2.10.2 • channel stable更新到Flutter 2.11.0-0.0.pre.695 • channel master的构建会奇妙的失败😥

@boyan01
Copy link
Owner

boyan01 commented Feb 28, 2022

十分感谢。失败的原因主要是这样的:

目前这个项目跟踪的是 flutter master channel(为了能否使用一些桌面的新特性,使用 channel master 来构建 )。而 master 的一些 api 可能与 stable channel 会有不同。

channel master 最近引入一个空安全的 change:flutter/flutter#89451 ,于是 WidgetsBinding.instance 的不再需要使用 !. 或者 ?. 了。

我也是最近才把这些多余的 !. 删掉的。 8a6c16b

@yzhe819
Copy link
Author

yzhe819 commented Feb 28, 2022

原来如此,刚刚找BUG的时候看到了这个👇
Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null
SchedulerBinding.instance! 也不再需要了

@yzhe819
Copy link
Author

yzhe819 commented Feb 28, 2022

跑起来后发现音乐库页面与发现页面一样,是发现页面还没完全实现吗?
非常感兴趣,有什么能贡献或者帮忙的吗?💖

找到一部分能帮忙的:

  • 搜索页面的实现

  • 发现页面的实现

  • 歌曲播放的评论

  • 歌曲播放的分享

@boyan01
Copy link
Owner

boyan01 commented Feb 28, 2022

跑起来后发现音乐库页面与发现页面一样,是发现页面还没完全实现吗?

对的。发现页面我没想好 UI 要怎么排列。(PC 端发现页面也只是随便糊了一下。

非常感兴趣,有什么能贡献或者帮忙的吗?💖

好的呀,非常欢迎。你列的这些功能点我觉得都 OK。不过你在做某个功能的时候,可以提个 DRAFT PULL REQUEST,表示自己在做这个功能;或者也可以提个 ISSUE,然后说明一些自己正在完成这个 ISSUE。

@yzhe819 yzhe819 closed this Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants